Page MenuHomeFreeBSD

lang/go: Update to 1.13.6 and switch to the new bootstrap
AcceptedPublic

Authored by dmgk on Jan 13 2020, 2:10 PM.

Details

Summary
  • Update to the 1.13.6
  • In preparation for go1.14 release, switch to the new bootstrap that supports freebsd/arm64
  • Sync with lang/go-devel port (add new makesum target, switch to dynamic pkg-plist generation)
Test Plan

Tested locally on 12.1-STABLE amd64, i386 and aarch64
exp-run?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28636
Build 26666: arc lint + arc unit

Event Timeline

dmgk created this revision.Jan 13 2020, 2:10 PM
dmgk updated this revision to Diff 66681.Jan 13 2020, 2:13 PM

Remove commented out SHEBANG_LANG

mikael accepted this revision.Jan 14 2020, 2:21 PM
This revision is now accepted and ready to land.Jan 14 2020, 2:21 PM
tobik accepted this revision.Mon, Jan 20, 2:09 PM
  • exp-run is probably not needed for this update, but should maybe happen when 1.14 is released
  • This looks like lang/go-devel now. Maybe it could be made a slave of lang/go later.
  • Ever considered creating a golang@FreeBSD.org maintainer group?
lang/go/Makefile
91–98

do-install, post-install could be merged and the two .for loops too.

112–123

Similar to rP523409 in lang/rust, ${GREP} ${GOARCH_${arch}:U${arch}} ${DISTINFO_FILE}.${arch} >> ${DISTINFO_FILE}.tmp can be simplified to ${SED} 1d ${DISTINFO_FILE}.${arch} >> ${DISTINFO_FILE}.tmp. The awk command below takes care of removing duplicate lines afterwards.

dmgk marked 2 inline comments as done.Fri, Feb 14, 6:14 PM
dmgk added inline comments.
lang/go/Makefile
112–123

I've fixed this in lang/go-devel, will update this review when go1.14 is out.