Page MenuHomeFreeBSD

Mk/Uses/go.mk: Avoid pollution of Go module cache with modules downloaded by gomod-vendor
AcceptedPublic

Authored by dmgk on Jan 6 2020, 11:54 PM.

Details

Reviewers
swills
tobik
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

Use module cache local to the WRKDIR and add the -modcacherw flag (available
in go1.14 [1, 2]) to instruct go mod vendor to leave directories
in the module cache read-write instead of making them unwritable.

[1] https://github.com/golang/go/issues/31481
[2] https://go-review.googlesource.com/c/go/+/202079/

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28514
Build 26569: arc lint + arc unit

Event Timeline

dmgk created this revision.Jan 6 2020, 11:54 PM
dmgk retitled this revision from Mk/Uses/go.mk: Avoid polluting Go module cache with modules downloaded by gomod-vendor to Mk/Uses/go.mk: Avoid pollution of Go module cache with modules downloaded by gomod-vendor.Jan 6 2020, 11:59 PM
swills accepted this revision.Jan 9 2020, 1:10 PM

Awesome, looks great, thanks!

This revision is now accepted and ready to land.Jan 9 2020, 1:10 PM