Page MenuHomeFreeBSD

Code must not unlock a mutex while owning the thread lock.
ClosedPublic

Authored by kib on Jan 13 2020, 10:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 25 2023, 6:07 AM
Unknown Object (File)
Dec 22 2023, 1:25 AM
Unknown Object (File)
Dec 19 2023, 3:20 PM
Unknown Object (File)
Nov 27 2023, 8:13 AM
Unknown Object (File)
Oct 27 2023, 12:23 PM
Unknown Object (File)
Sep 30 2023, 7:07 PM
Unknown Object (File)
Sep 21 2023, 10:10 PM
Unknown Object (File)
Sep 7 2023, 4:25 AM

Details

Summary

Sponsored by: Mellanox Technologies

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 28634

Event Timeline

sys/compat/linuxkpi/common/src/linux_rcu.c has same bug. Please also fix there.

Should thread_lock() assert Giant not owned?

Should thread_lock() assert Giant not owned?

I do not think so. It might make sense to make a witness assert that no sleepable mutexes are owned, but really the check for recursion in the thread_lock_flags() catches the problematic cases.

Also change linux RCU code.

This revision is now accepted and ready to land.Jan 13 2020, 10:56 AM