Differential D23095

malloc_domain(): return the allocation size to the caller.
ClosedPublic
Actions

Authored by markj on Jan 8 2020, 9:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 2, 1:47 PM

	Unknown Object (File)
	Thu, May 2, 12:21 PM

	Unknown Object (File)
	Thu, May 2, 12:21 PM

	Unknown Object (File)
	Thu, May 2, 10:24 AM

	Unknown Object (File)
	Thu, Apr 18, 9:16 AM

	Unknown Object (File)
	Apr 4 2024, 1:35 AM

	Unknown Object (File)
	Mar 29 2024, 11:13 AM

	Unknown Object (File)
	Jan 10 2024, 2:46 AM

View All 21 Files

Subscribers

Details

Reviewers

jeff
rlibby

Commits

rS356555: Change malloc_domain() to return the allocation size to the caller.

Summary

Otherwise malloc type accounting is wrong.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28556
Build 26606: arc lint + arc unit

Event Timeline

markj created this revision.Jan 8 2020, 9:28 PM

Harbormaster completed remote builds in B28556: Diff 66520.Jan 8 2020, 9:28 PM

markj added reviewers: jeff, rlibby.Jan 8 2020, 9:29 PM

markj added a subscriber: kaktus.

lgtm, at least from the vmstat -m perspective

Looks good. Did this fix the bus-sc accounting?

sys/kern/kern_malloc.c
673	Too bad the compiler didn't warn about this.

This revision is now accepted and ready to land.Jan 8 2020, 10:23 PM

In D23095#506160, @rlibby wrote:

Looks good. Did this fix the bus-sc accounting?

Yes. I'm not sure about the M_TEMP issue though, I only see a couple of malloc_domainset(M_TEMP) callers and they don't look to be responsible.

Closed by commit rS356555: Change malloc_domain() to return the allocation size to the caller. (authored by markj). · Explain WhyJan 9 2020, 3:02 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS356555: Change malloc_domain() to return the allocation size to the caller..

Herald added a subscriber: imp. · View Herald TranscriptJan 9 2020, 3:02 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

15 lines

Diff 66520

sys/kern/kern_malloc.c

Loading...