Page MenuHomeFreeBSD
Differential D23095

malloc_domain(): return the allocation size to the caller.
ClosedPublic
Actions

Authored by markj on Jan 8 2020, 9:28 PM.
Tags
None
Referenced Files
F165251045: D23095.diff
Fri, Aug 7, 4:36 AM
Unknown Object (File)
Wed, Aug 5, 9:11 AM
Unknown Object (File)
Tue, Aug 4, 8:03 AM
Unknown Object (File)
Sun, Aug 2, 2:39 AM
Unknown Object (File)
Wed, Jul 29, 12:03 AM
Unknown Object (File)
Wed, Jul 8, 9:23 PM
Unknown Object (File)
Jul 6 2026, 2:31 PM
Unknown Object (File)
Jun 28 2026, 2:00 PM
View All Files
Subscribers
imp
kaktus

Details

Reviewers
jeff
rlibby
Commits
rS356555: Change malloc_domain() to return the allocation size to the caller.
Summary

Otherwise malloc type accounting is wrong.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28556
Build 26606: arc lint + arc unit

Event Timeline

markj created this revision.Jan 8 2020, 9:28 PM
Harbormaster completed remote builds in B28556: Diff 66520.Jan 8 2020, 9:28 PM
markj added reviewers: jeff, rlibby.Jan 8 2020, 9:29 PM
markj added a subscriber: kaktus.
kaktus added a comment.Jan 8 2020, 9:43 PM

lgtm, at least from the vmstat -m perspective

rlibby accepted this revision.Jan 8 2020, 10:23 PM

Looks good. Did this fix the bus-sc accounting?

sys/kern/kern_malloc.c
673

Too bad the compiler didn't warn about this.

This revision is now accepted and ready to land.Jan 8 2020, 10:23 PM
markj added a comment.Jan 8 2020, 10:45 PM
In D23095#506160, @rlibby wrote:

Looks good. Did this fix the bus-sc accounting?

Yes. I'm not sure about the M_TEMP issue though, I only see a couple of malloc_domainset(M_TEMP) callers and they don't look to be responsible.

Closed by commit rS356555: Change malloc_domain() to return the allocation size to the caller. (authored by markj). · Explain WhyJan 9 2020, 3:02 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS356555: Change malloc_domain() to return the allocation size to the caller..
Herald added a subscriber: imp. · View Herald TranscriptJan 9 2020, 3:02 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
15 lines

Diff 66520

View Options

sys/kern/kern_malloc.c

Loading...