Page MenuHomeFreeBSD

malloc_domain(): return the allocation size to the caller.
ClosedPublic

Authored by markj on Jan 8 2020, 9:28 PM.
Tags
None
Referenced Files
F80228945: D23095.id66520.diff
Fri, Mar 29, 11:13 AM
Unknown Object (File)
Jan 10 2024, 2:46 AM
Unknown Object (File)
Jul 1 2023, 8:23 AM
Unknown Object (File)
Jul 1 2023, 8:19 AM
Unknown Object (File)
Jul 1 2023, 8:12 AM
Unknown Object (File)
Jul 1 2023, 7:57 AM
Unknown Object (File)
Jun 21 2023, 4:32 AM
Unknown Object (File)
May 2 2023, 4:32 PM
Subscribers

Details

Summary

Otherwise malloc type accounting is wrong.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lgtm, at least from the vmstat -m perspective

Looks good. Did this fix the bus-sc accounting?

sys/kern/kern_malloc.c
673 ↗(On Diff #66520)

Too bad the compiler didn't warn about this.

This revision is now accepted and ready to land.Jan 8 2020, 10:23 PM

Looks good. Did this fix the bus-sc accounting?

Yes. I'm not sure about the M_TEMP issue though, I only see a couple of malloc_domainset(M_TEMP) callers and they don't look to be responsible.