Page MenuHomeFreeBSD

malloc_domain(): return the allocation size to the caller.
ClosedPublic

Authored by markj on Jan 8 2020, 9:28 PM.

Details

Summary

Otherwise malloc type accounting is wrong.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.Jan 8 2020, 9:28 PM
markj added a subscriber: kaktus.
kaktus added a comment.Jan 8 2020, 9:43 PM

lgtm, at least from the vmstat -m perspective

rlibby accepted this revision.Jan 8 2020, 10:23 PM

Looks good. Did this fix the bus-sc accounting?

sys/kern/kern_malloc.c
673 ↗(On Diff #66520)

Too bad the compiler didn't warn about this.

This revision is now accepted and ready to land.Jan 8 2020, 10:23 PM
markj added a comment.Jan 8 2020, 10:45 PM

Looks good. Did this fix the bus-sc accounting?

Yes. I'm not sure about the M_TEMP issue though, I only see a couple of malloc_domainset(M_TEMP) callers and they don't look to be responsible.