Page MenuHomeFreeBSD
Differential D22187

Add sigsetop extensions commonly found in musl libc and glibc
ClosedPublic
Actions

Authored by kevans on Oct 30 2019, 3:29 AM.
Tags
None
Referenced Files
F168869449: D22187.id.diff
Sun, Aug 30, 1:06 PM
Unknown Object (File)
Wed, Aug 26, 6:22 PM
Unknown Object (File)
Wed, Aug 26, 12:08 PM
Unknown Object (File)
Wed, Aug 26, 11:17 AM
Unknown Object (File)
Thu, Aug 13, 7:01 PM
Unknown Object (File)
Mon, Aug 10, 2:58 PM
Unknown Object (File)
Mon, Aug 10, 2:49 PM
Unknown Object (File)
Wed, Aug 5, 5:14 AM
View All Files
Subscribers
imp

Details

Reviewers
jilles
bapt
pfg
Group Reviewers
manpages
Commits
rS355641: Add sigsetop extensions commonly found in musl libc and glibc
Summary

These functions are commonly available in at least musl libc and glibc; sigorset, at least, has proven quite useful in qemu-bsd-user work for tracking the current process signal mask in a more self-documenting/aesthetically pleasing manner.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Oct 30 2019, 3:29 AM
Herald added a reviewer: manpages. · View Herald TranscriptOct 30 2019, 3:29 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B27270: Diff 63783.Oct 30 2019, 3:29 AM
kevans added reviewers: bapt, pfg.Dec 11 2019, 1:45 PM

Adding bapt and pfg- perhaps they have an opinion. =-)

pfg added a comment.Dec 11 2019, 2:32 PM

LGTM, I like sensible extensions.

include/signal.h
132 ↗(On Diff #63783)

Alphabetical order please. :)

bapt accepted this revision.Dec 11 2019, 3:26 PM

look good to me as well

This revision is now accepted and ready to land.Dec 11 2019, 3:26 PM
kevans added inline comments.Dec 11 2019, 4:42 PM
include/signal.h
132 ↗(On Diff #63783)

Will slide around pre-commit

pfg accepted this revision.Dec 11 2019, 7:02 PM
jilles accepted this revision.Dec 11 2019, 7:08 PM
Closed by commit rS355641: Add sigsetop extensions commonly found in musl libc and glibc (authored by kevans). · Explain WhyDec 12 2019, 1:42 AM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rS355641: Add sigsetop extensions commonly found in musl libc and glibc.

Revision Contents
Changeset List

PathSize
head/
include/
3 lines
lib/
libc/
gen/
5 lines
6 lines
55 lines
31 lines
tests/
gen/
1 line
191 lines

Diff 65528

View Options

head/include/signal.h

Loading...
View Options

head/lib/libc/gen/Makefile.inc

Loading...
View Options

head/lib/libc/gen/Symbol.map

Loading...
View Options

head/lib/libc/gen/sigsetops.3

Loading...
View Options

head/lib/libc/gen/sigsetops.c

Loading...
View Options

head/lib/libc/tests/gen/Makefile

Loading...
View Options

head/lib/libc/tests/gen/sigsetops_test.c

Loading...