Initialize the idlethread lock pointer earlier so we don't evaluate it onvery fork exit.
ClosedPublic
Actions

Authored by jeff on Dec 1 2019, 8:39 PM.

Details

Reviewers

mav
kib
jhb
mjg
markj

Commits

rS355312: Initialize the idle thread's lock sooner so it's not evaluated on every fork

Summary

This is a minor optimization from https://github.com/freebsd/freebsd/compare/master...jwroberson:schedlock

It's as simple as the title says.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27874
Build 26045: arc lint + arc unit

Event Timeline

jeff created this revision.Dec 1 2019, 8:39 PM

Harbormaster completed remote builds in B27874: Diff 65104.Dec 1 2019, 8:39 PM

jeff retitled this revision from Initialize the idlethread lock pointer earlier so we don't evaluate it on very fork exit. to Initialize the idlethread lock pointer earlier so we don't evaluate it onvery fork exit..Dec 1 2019, 8:40 PM

jeff edited the summary of this revision. (Show Details)

jeff added reviewers: mav, kib, jhb, mjg, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptDec 1 2019, 8:40 PM

kib accepted this revision.Dec 1 2019, 9:00 PM

This revision is now accepted and ready to land.Dec 1 2019, 9:00 PM

I am not very familiar with this path, but seems OK.

markj accepted this revision.Dec 2 2019, 4:37 PM

jhb accepted this revision.Dec 2 2019, 9:02 PM

Closed by commit rS355312: Initialize the idle thread's lock sooner so it's not evaluated on every fork (authored by jeff). · Explain WhyDec 2 2019, 10:36 PM

This revision was automatically updated to reflect the committed changes.

jeff added a commit: rS355312: Initialize the idle thread's lock sooner so it's not evaluated on every fork.

Revision Contents
Changeset List

Path

Size

sys/

kern/

sched_ule.c

5 lines

Diff 65104

View Options

Initialize the idlethread lock pointer earlier so we don't evaluate it onvery fork exit.ClosedPublicActions