Refactor uma_zfree_arg()
ClosedPublic
Actions

Authored by jeff on Nov 21 2019, 10:40 PM.

Details

Reviewers

markj
glebius
kib
cem
rlibby

Commits

rS355148: Refactor uma_zfree_arg into several functions to make control flow more

Summary

This is a more significant refactoring than uma_zalloc_arg() because it was in worse shape. We only need the zone lock if we're going to cache a bucket. The crossdomain logic really needed to be simplified and merged with the other case. Fundamentally we're just freeing a bucket and allocating a bucket, no matter which bucket that is.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27787
Build 25973: arc lint + arc unit

Event Timeline

jeff created this revision.Nov 21 2019, 10:40 PM

Harbormaster completed remote builds in B27700: Diff 64701.Nov 21 2019, 10:40 PM

jeff edited the summary of this revision. (Show Details)Nov 21 2019, 10:47 PM

jeff added reviewers: markj, glebius, kib, cem.

The bucket_push and item_dtor refactors look reasonable. I'm not super familiar with this area of code.

markj added inline comments.Nov 22 2019, 3:34 PM

sys/vm/uma_core.c
3274	Missing space after `while`.
3380	Isn't the use of `lockfail` redundant? We can write: if (!ZONE_TRYLOCK(zone)) { ZONE_LOCK(zone); if (zone->uz_count < zone->uz_count_max) .... }