vm_object_collapse_scan_wait: drop locks before reacquring
ClosedPublic
Actions

Authored by rlibby on Nov 25 2019, 1:10 AM.

Tags

None

Referenced Files

	F163272418: D22542.id64837.diff
	Tue, Jul 21, 3:26 PM

	Unknown Object (File)
	Mon, Jul 20, 12:09 AM

	Unknown Object (File)
	Sat, Jul 18, 3:30 AM

	Unknown Object (File)
	Sun, Jul 5, 3:47 PM

	Unknown Object (File)
	Sun, Jun 28, 1:44 AM

	Unknown Object (File)
	Tue, Jun 23, 7:22 PM

	Unknown Object (File)
	May 14 2026, 9:45 AM

	Unknown Object (File)
	May 11 2026, 12:55 PM

Subscribers

Details

Reviewers

markj
jeff

Commits

rS355084: vm_object_collapse_scan_wait: drop locks before reacquiring

Summary

Regression from r352174. In the vm_page_rename() failure case we forgot
to unlock the vm object locks before sleeping and reacquiring them.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Nov 25 2019, 1:10 AM

Harbormaster completed remote builds in B27753: Diff 64837.Nov 25 2019, 1:10 AM

thank you

This revision is now accepted and ready to land.Nov 25 2019, 2:34 AM

Closed by commit rS355084: vm_object_collapse_scan_wait: drop locks before reacquiring (authored by rlibby). · Explain WhyNov 25 2019, 7:38 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rS355084: vm_object_collapse_scan_wait: drop locks before reacquiring.

Herald added a subscriber: imp. · View Herald TranscriptNov 25 2019, 7:38 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_object.c

2 lines

Diff 64844

View Options

vm_object_collapse_scan_wait: drop locks before reacquringClosedPublicActions