gnop: add the option for adding a suffix to the name of the device
ClosedPublic
Actions

Authored by oshogbo on Nov 10 2019, 11:48 AM.

Details

Reviewers

markj
bcr
allanjude

Group Reviewers

manpages

Commits

rS356174: gnop: allow to change the name of created device

Summary

Thanks to this option we can create more then one gnop provider from
single provider. This may be useful for temporary labeling some data
on the disk.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27613
Build 25826: arc lint + arc unit

Event Timeline

oshogbo created this revision.Nov 10 2019, 11:48 AM

Harbormaster completed remote builds in B27429: Diff 64146.Nov 10 2019, 11:48 AM

oshogbo added reviewers: markj, bcr, allanjude.Nov 10 2019, 11:49 AM

Why don't we just have a "name" parameter that determines the entire gnop provider name?

In D22304#487863, @markj wrote:

Why don't we just have a "name" parameter that determines the entire gnop provider name?

I like Mark's idea, change the flag to just let you specify the entire name of the resulting provider (the parameter passed to g_new_geomf())

I'm fine with naming nop devices any name as long as there is a nop suffix.
Otherwise somebody may do some weird stuff in /dev/.

Harbormaster completed remote builds in B27613: Diff 64512.Nov 18 2019, 12:15 AM

markj added inline comments.Nov 27 2019, 5:16 PM

lib/geom/nop/gnop.8
158	Should be "the new provider".
159	I think it would be clearer to refer to it as a suffix. For example, "The suffix .Dq .nop will be appended to the provider name."
sys/geom/nop/g_nop.c
33	param.h is special and should come first in the include order.
91	Why not write these as boolean expressions? `if (!islower(name[i]) && !isdigit(name[i])) ...` I do not see why upper case characters should be prohibited.
392	Perhaps include the name in the error message.