Details

Reviewers

kib
alc

Commits

rS354785: The loop in vm_map_protect that verifies that all transition map

Summary

The loop in vm_map_protect that verifies that all transition map
entries are stabilized, repeatedly verifies the same entry. Check each
entry in turn.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Nov 16 2019, 6:30 AM

kib accepted this revision.Nov 16 2019, 10:22 AM

This revision is now accepted and ready to land.Nov 16 2019, 10:22 AM

The code is correct, but the summary is wrong.

dougm retitled this revision from look for protection violations in each map entry to look for in-transition status in each map entry.Nov 16 2019, 4:45 PM

dougm edited the summary of this revision. (Show Details)

Clean up the comment following the change.

This revision now requires review to proceed.Nov 16 2019, 5:16 PM

alc added inline comments.Nov 16 2019, 5:28 PM

sys/vm/vm_map.c
2479 ↗	(On Diff #64449)	" ... but not yet have its MAP_ENTRY_USER_WIRED flag set and visible ...

dougm updated this revision to Diff 64450.Nov 16 2019, 5:34 PM

dougm marked an inline comment as done.

While I think that this change is unquestionably correct, I would still ask Peter to test it.

sys/vm/vm_map.c
2480–2481 ↗	(On Diff #64449)	I think that the "and" clause can simply be deleted. In other worlds, we can simply say, "... flag set. In which case, we would fail to ..."