Page MenuHomeFreeBSD

look for in-transition status in each map entry
ClosedPublic

Authored by dougm on Nov 16 2019, 6:30 AM.

Details

Summary

The loop in vm_map_protect that verifies that all transition map
entries are stabilized, repeatedly verifies the same entry. Check each
entry in turn.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dougm created this revision.Nov 16 2019, 6:30 AM
kib accepted this revision.Nov 16 2019, 10:22 AM
This revision is now accepted and ready to land.Nov 16 2019, 10:22 AM
alc added a comment.Nov 16 2019, 4:42 PM

The code is correct, but the summary is wrong.

dougm retitled this revision from look for protection violations in each map entry to look for in-transition status in each map entry.Nov 16 2019, 4:45 PM
dougm edited the summary of this revision. (Show Details)
dougm updated this revision to Diff 64449.Nov 16 2019, 5:16 PM

Clean up the comment following the change.

This revision now requires review to proceed.Nov 16 2019, 5:16 PM
alc added inline comments.Nov 16 2019, 5:28 PM
sys/vm/vm_map.c
2479 ↗(On Diff #64449)

" ... but not yet have its MAP_ENTRY_USER_WIRED flag set and visible ...

dougm updated this revision to Diff 64450.Nov 16 2019, 5:34 PM
dougm marked an inline comment as done.
alc added a comment.Nov 16 2019, 7:13 PM

While I think that this change is unquestionably correct, I would still ask Peter to test it.

sys/vm/vm_map.c
2480–2481 ↗(On Diff #64449)

I think that the "and" clause can simply be deleted. In other worlds, we can simply say, "... flag set. In which case, we would fail to ..."

dougm updated this revision to Diff 64459.Nov 16 2019, 7:16 PM
dougm added a subscriber: pho.
pho added a comment.Nov 17 2019, 5:59 AM

I tested D22405.64459.diff for 10 hours without seeing any problems.

alc accepted this revision.Nov 17 2019, 6:46 AM
This revision is now accepted and ready to land.Nov 17 2019, 6:46 AM
This revision was automatically updated to reflect the committed changes.