bsnmp: Fix operator precedence in error check in table_check_response
ClosedPublic
Actions

Authored by jhibbits on Nov 17 2019, 5:00 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 9, 5:40 PM

	Unknown Object (File)
	Thu, Apr 9, 10:15 AM

	Unknown Object (File)
	Wed, Apr 8, 9:50 PM

	Unknown Object (File)
	Mon, Apr 6, 12:54 PM

	Unknown Object (File)
	Sun, Apr 5, 11:17 AM

	Unknown Object (File)
	Wed, Mar 25, 2:37 AM

	Unknown Object (File)
	Tue, Mar 24, 5:54 PM

	Unknown Object (File)
	Tue, Mar 24, 6:00 AM

View All Files

Subscribers

imp

Details

Reviewers

ngie
ae

Commits

rS360301: MFC r354834 (by jhibbits):
rS354834: bsnmp: Fix operator precedence in error check in table_check_response

Summary

The ?: operator has a lower precedence than == and &&, so the result will always
be recorded as true. Found by gcc8.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 27600
Build 25817: arc lint + arc unit

Event Timeline

jhibbits created this revision.Nov 17 2019, 5:00 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 17 2019, 5:00 AM

Harbormaster completed remote builds in B27600: Diff 64481.Nov 17 2019, 5:00 AM

LGTM.

This revision is now accepted and ready to land.Nov 18 2019, 11:46 AM

Macro lgtm:

Closed by commit rS354834: bsnmp: Fix operator precedence in error check in table_check_response (authored by jhibbits). · Explain WhyNov 18 2019, 11:23 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rS354834: bsnmp: Fix operator precedence in error check in table_check_response.

dim added a commit: rS360301: MFC r354834 (by jhibbits):.Apr 25 2020, 12:57 PM

Revision Contents
Changeset List

Path

Size

contrib/

bsnmp/

lib/

snmpclient.c

2 lines

Diff 64481

View Options

contrib/bsnmp/lib/snmpclient.c

bsnmp: Fix operator precedence in error check in table_check_responseClosedPublicActions