Add sync_file_range(2) to linux(4).
ClosedPublic
Actions

Authored by trasz on Nov 14 2019, 2:00 PM.

Details

Reviewers

manu
brooks
emaste

Group Reviewers

Linux Emulation

Commits

rS355753: Regen after r355752.
rS355754: Add sync_file_range(2) implementation to linux(4); it's a thin wrapper
rS355752: Fix definitions for linuxulator's sync_file_range(2).

Summary

Add sync_file_range(2) implementation to linux(4); underneath it's a wrapper over the usual fsync(2). This silences some warnings when running "apt-get upgrade".

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27520
Build 25749: arc lint + arc unit

Event Timeline

trasz created this revision.Nov 14 2019, 2:00 PM

Herald added a reviewer: manu. · View Herald TranscriptNov 14 2019, 2:00 PM

Herald added a reviewer: brooks. · View Herald Transcript

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

Harbormaster completed remote builds in B27510: Diff 64319.Nov 14 2019, 2:01 PM

trasz edited the summary of this revision. (Show Details)Nov 14 2019, 2:02 PM

trasz added a reviewer: Linux Emulation.

emaste added inline comments.Nov 14 2019, 2:06 PM

sys/compat/linux/linux_file.c
916	This is a perfectly reasonable way to implement this in the linuxulator, but we should have some way to track this in the future, maybe a probe as done elsewhere in the linuxulator?
sys/compat/linux/linux_file.h
137	Should have a comment `sync_file_range flags`?

brooks added inline comments.Nov 14 2019, 5:00 PM

sys/arm/linux/syscalls.master
1701	Remove the `);` on this line. It's interesting that this worked at all...
sys/arm64/linux/syscalls.master
457	Another extra `);`. Note that the sys calls above have the wrong style (`);` should be on it's own line).

trasz added inline comments.Nov 14 2019, 9:55 PM

sys/compat/linux/linux_file.c
916	I’m not quite sure what you mean?

Fix most of the problems.

Harbormaster completed remote builds in B27520: Diff 64343.Nov 14 2019, 10:03 PM

emaste added inline comments.Nov 14 2019, 10:05 PM

sys/compat/linux/linux_file.c
916	sorry I didn't provide enough context. From linux sync_file_range manpage: offset is the starting byte of the file range to be synchronized. nbytes specifies the length of the range to be synchronized, in bytes so for the purpose of the linuxulator it's reasonable to translate this to plain kern_fsync, but we should have some reminder or other way to know we should revisit this in the future if we grow a FreeBSD interface for fine-grained sync