Paths

Table of Contentst

Differential D22357

Combine ELF sysvecs for MIPS to reduce code duplication.
ClosedPublic
Actions

Authored by jhb on Nov 13 2019, 11:05 PM.

Tags

None

Referenced Files

	F115263076: D22357.id64294.diff
	Tue, Apr 22, 12:15 AM

	F115246190: D22357.id64392.diff
	Mon, Apr 21, 8:11 PM

	Unknown Object (File)
	Mon, Apr 21, 3:44 AM

	Unknown Object (File)
	Sun, Apr 20, 1:07 PM

	Unknown Object (File)
	Sun, Apr 20, 12:51 PM

	Unknown Object (File)
	Sun, Apr 20, 12:51 PM

	Unknown Object (File)
	Sun, Apr 20, 12:45 PM

	Unknown Object (File)
	Sun, Apr 20, 12:43 PM

View All 59 Files

Subscribers

Details

Reviewers

brooks
kevans

Commits

rS354744: Combine ELF sysvecs for MIPS to reduce code duplication.

Summary

Tested on: mips, mips64

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27502
Build 25734: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 13 2019, 11:05 PM

Harbormaster completed remote builds in B27502: Diff 64294.Nov 13 2019, 11:05 PM

brooks added inline comments.Nov 13 2019, 11:24 PM

sys/mips/mips/elf_machdep.c
54	Should this be `__elfN(freebsd_sysvec)` to match the things below and preserve the name of the public symbol?

jhb added a parent revision: D22355: Add a sv_copyout_auxargs() hook in sysentvec..Nov 13 2019, 11:45 PM

jhb added inline comments.Nov 13 2019, 11:52 PM

sys/mips/mips/elf_machdep.c
54	It doesn't have to be, and really it could be a static variable instead of a global. It's just passed as the pointer in the .sysvec array, there aren't any other references to it. Note that the brand info is called 'freebsd_brand_info' instead of 'freebsd32/64_brand_info'. Ironically, sparc64 gets this right and marks it static. Looks like i386 does have a few other references to the elf32_freebsd_sysvec for some one-off special cases and that the lack of static was just copied from i386 to other platforms due to cargo cult.

It's probably worth making elf_freebsd_sysvec static, but this is fine.

This revision is now accepted and ready to land.Nov 15 2019, 6:14 PM

I will make it static for commit.

Closed by commit rS354744: Combine ELF sysvecs for MIPS to reduce code duplication. (authored by jhb). · Explain WhyNov 15 2019, 7:00 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS354744: Combine ELF sysvecs for MIPS to reduce code duplication..

Herald added a subscriber: imp. · View Herald TranscriptNov 15 2019, 7:00 PM

Revision Contents
Changeset List

Path

Size

sys/

mips/

mips/

75 lines

Diff 64294

sys/mips/mips/elf_machdep.c

Loading...