Force MK_CLANG_IS_CC on in XMAKE.
ClosedPublic
Actions

Authored by jhb on Nov 12 2019, 5:07 PM.

Tags

None

Referenced Files

	F159436395: D22332.id64249.diff
	Sun, Jun 14, 2:07 AM

	Unknown Object (File)
	Wed, Jun 10, 10:19 AM

	Unknown Object (File)
	Mon, Jun 8, 6:35 PM

	Unknown Object (File)
	Fri, May 15, 8:31 PM

	Unknown Object (File)
	Fri, May 15, 8:25 PM

	Unknown Object (File)
	May 13 2026, 10:46 PM

	Unknown Object (File)
	May 8 2026, 7:40 PM

	Unknown Object (File)
	May 3 2026, 3:59 AM

View All 100 Files

Subscribers

emaste

mhorne

Details

Reviewers

bdrewery
imp

Commits

rS354661: Force MK_CLANG_IS_CC on in XMAKE.

Summary

This ensures that a bootstrap clang compiler is always installed as
cc in WORLDTMP. If it is only installed as 'clang' then /usr/bin/cc
is used during the build instead of the bootstrap compiler.

Test Plan

tried to build riscv64sf with WITH_CLANG_BOOTSTRAP=yes but without WITH_CLANG_IS_CC=yes

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 27475
Build 25707: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 12 2019, 5:07 PM

Harbormaster completed remote builds in B27475: Diff 64241.Nov 12 2019, 5:07 PM

imp accepted this revision.Nov 12 2019, 5:40 PM

This revision is now accepted and ready to land.Nov 12 2019, 5:40 PM

Hmmm, does this break native builds for gcc?

It shouldn't. The only thing that honors MK_CLANG_IS_CC is the clang Makefile, and during XMAKE we only enter that subdirectory if MK_CLANG_BOOSTRAP is yes, and we shouldn't have both that and MK_GCC_BOOTSTRAP as yes at the same time.

Closed by commit rS354661: Force MK_CLANG_IS_CC on in XMAKE. (authored by jhb). · Explain WhyNov 12 2019, 9:30 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS354661: Force MK_CLANG_IS_CC on in XMAKE..

Revision Contents
Changeset List

Path

Size

Makefile.inc1

1 line

Diff 64241

View Options

Force MK_CLANG_IS_CC on in XMAKE.ClosedPublicActions