Page MenuHomeFreeBSD

Force MK_CLANG_IS_CC on in XMAKE.
ClosedPublic

Authored by jhb on Nov 12 2019, 5:07 PM.
Tags
None
Referenced Files
F107764923: D22332.diff
Sat, Jan 18, 1:18 AM
Unknown Object (File)
Fri, Jan 3, 3:15 AM
Unknown Object (File)
Dec 15 2024, 12:56 PM
Unknown Object (File)
Dec 11 2024, 4:26 PM
Unknown Object (File)
Dec 10 2024, 11:07 PM
Unknown Object (File)
Nov 19 2024, 9:21 AM
Unknown Object (File)
Nov 19 2024, 8:34 AM
Unknown Object (File)
Nov 18 2024, 12:44 AM
Subscribers

Details

Summary

This ensures that a bootstrap clang compiler is always installed as
cc in WORLDTMP. If it is only installed as 'clang' then /usr/bin/cc
is used during the build instead of the bootstrap compiler.

Test Plan
  • tried to build riscv64sf with WITH_CLANG_BOOTSTRAP=yes but without WITH_CLANG_IS_CC=yes

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 27475
Build 25707: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Nov 12 2019, 5:40 PM

Hmmm, does this break native builds for gcc?

It shouldn't. The only thing that honors MK_CLANG_IS_CC is the clang Makefile, and during XMAKE we only enter that subdirectory if MK_CLANG_BOOSTRAP is yes, and we shouldn't have both that and MK_GCC_BOOTSTRAP as yes at the same time.

This revision was automatically updated to reflect the committed changes.