Page MenuHomeFreeBSD
Differential D22284

Enable the RISCV LLVM backend by default.
ClosedPublic
Actions

Authored by jhb on Nov 8 2019, 5:58 PM.
Tags
None
Referenced Files
F109255505: D22284.diff
Sun, Feb 2, 4:35 PM
Unknown Object (File)
Fri, Jan 10, 4:08 PM
Unknown Object (File)
Nov 15 2024, 2:56 AM
Unknown Object (File)
Oct 29 2024, 8:48 PM
Unknown Object (File)
Oct 28 2024, 6:29 AM
Unknown Object (File)
Oct 28 2024, 6:29 AM
Unknown Object (File)
Oct 28 2024, 6:28 AM
Unknown Object (File)
Oct 28 2024, 6:28 AM
View All 67 Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
dim
mhorne
emaste
Commits
rS354660: Enable the RISC-V LLVM backend by default.
Test Plan
  • able to build riscv64sf world with clang and external binutils
  • tested a world built with WITHOUT_LLVM_TARGET_ALL

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 27474
Build 25706: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 8 2019, 5:58 PM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptNov 8 2019, 5:58 PM
Harbormaster completed remote builds in B27400: Diff 64084.Nov 8 2019, 5:59 PM
dim accepted this revision.Nov 8 2019, 6:20 PM

LGTM.

This revision is now accepted and ready to land.Nov 8 2019, 6:20 PM
emaste added a comment.Nov 8 2019, 6:20 PM

LGTM

share/mk/src.opts.mk
314

We should also take riscv out of here at the same time (if it's not moving to the first block right away) - so that independent of the bootstrap compiler question we have a target Clang.

emaste accepted this revision.Nov 8 2019, 6:20 PM
mhorne accepted this revision.Nov 8 2019, 9:13 PM

I presume hard-float world can't be built yet due to https://reviews.llvm.org/D66725 still being uncommitted?

jhb added inline comments.Nov 8 2019, 10:10 PM
share/mk/src.opts.mk
314

It can't move to the first block due to the hard-float issue, but we could take it out of here, yes.

jhb updated this revision to Diff 64240.Nov 12 2019, 5:06 PM
  • Enable building of clang by default on riscv.
This revision now requires review to proceed.Nov 12 2019, 5:06 PM
Harbormaster completed remote builds in B27474: Diff 64240.Nov 12 2019, 5:06 PM
jhb marked an inline comment as done.Nov 12 2019, 5:13 PM
emaste accepted this revision.Nov 12 2019, 5:17 PM
This revision is now accepted and ready to land.Nov 12 2019, 5:17 PM
dim accepted this revision.Nov 12 2019, 6:03 PM
Closed by commit rS354660: Enable the RISC-V LLVM backend by default. (authored by jhb). · Explain WhyNov 12 2019, 9:27 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS354660: Enable the RISC-V LLVM backend by default..
Herald added a subscriber: imp. · View Herald TranscriptNov 12 2019, 9:27 PM

Revision Contents
Changeset List

PathSize
share/
mk/
4 lines

Diff 64240

View Options

share/mk/src.opts.mk

Loading...