llvm-devel on powerpc64: add configure option to select ELFv2 ABI
ClosedPublic
Actions

Authored by alfredo on Oct 21 2019, 7:17 PM.

Details

Reviewers

brooks
pkubaj
mikael
linimon

Commits

rP515154: Update to a new snapshot.

Summary

In preparation for compiler+ABI change in PowerPC64, this change adds a configure option to select ELFv2 as default powerpc64 ABI when compiling llvm-devel.

The new option automatically set when ELFv2 environment is detected (when PPC_ABI=ELFv2)

I plan to propose same change for llvm90 package, as long this one is approved

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 27141
Build 25416: arc lint + arc unit

Event Timeline

alfredo created this revision.Oct 21 2019, 7:17 PM

Harbormaster completed remote builds in B27141: Diff 63519.Oct 21 2019, 7:17 PM

alfredo edited the summary of this revision. (Show Details)Oct 21 2019, 7:21 PM

alfredo added reviewers: brooks, pkubaj, mikael, linimon.

alfredo added a child revision: D21588: [PowerPC64] fix www/node build and runtime when using ELFv2 ABI.

alfredo added a subscriber: bdragon.

alfredo edited the summary of this revision. (Show Details)Oct 21 2019, 8:22 PM

This looks good. I would like to commit it myself along with an update of the port to limit needless rebuilds (options changes require PORTREVISION bumps).

This revision is now accepted and ready to land.Oct 21 2019, 9:14 PM

In D22100#483005, @brooks wrote:

This looks good. I would like to commit it myself along with an update of the port to limit needless rebuilds (options changes require PORTREVISION bumps).

Thanks! I'll prepare the patch for llvm90, it should be the same.
This change depends on D22039 to be active, but it looks safe to be committed anytime since ".if defined(PPC_ABI)" guards it.

Closed by commit rP515154: Update to a new snapshot. (authored by brooks). · Explain WhyOct 21 2019, 11:53 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rP515154: Update to a new snapshot..

brooks mentioned this in rP515213: Fix build without CLANG enabled. [0].Oct 22 2019, 7:07 PM

brooks mentioned this in rP515935: MFH: r513490 r514194 r515213.Oct 28 2019, 9:04 PM