Page MenuHomeFreeBSD
Differential D22100

llvm-devel on powerpc64: add configure option to select ELFv2 ABI
ClosedPublic
Actions

Authored by alfredo on Oct 21 2019, 7:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 12:15 AM
Unknown Object (File)
Fri, Mar 7, 6:25 AM
Unknown Object (File)
Wed, Feb 26, 11:18 PM
Unknown Object (File)
Feb 23 2025, 12:04 AM
Unknown Object (File)
Feb 21 2025, 6:09 PM
Unknown Object (File)
Feb 9 2025, 1:43 PM
Unknown Object (File)
Dec 6 2024, 9:06 PM
Unknown Object (File)
Nov 23 2024, 4:25 PM
View All Files
Subscribers
bdragon
luporl

Details

Reviewers
brooks
pkubaj
mikael
linimon
Commits
rP515154: Update to a new snapshot.
Summary

In preparation for compiler+ABI change in PowerPC64, this change adds a configure option to select ELFv2 as default powerpc64 ABI when compiling llvm-devel.

The new option automatically set when ELFv2 environment is detected (when PPC_ABI=ELFv2)

I plan to propose same change for llvm90 package, as long this one is approved

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 27141
Build 25416: arc lint + arc unit

Event Timeline

alfredo created this revision.Oct 21 2019, 7:17 PM
Harbormaster completed remote builds in B27141: Diff 63519.Oct 21 2019, 7:17 PM
alfredo edited the summary of this revision. (Show Details)Oct 21 2019, 7:21 PM
alfredo added reviewers: brooks, pkubaj, mikael, linimon.
alfredo added a child revision: D21588: [PowerPC64] fix www/node build and runtime when using ELFv2 ABI.
alfredo added a subscriber: bdragon.
alfredo edited the summary of this revision. (Show Details)Oct 21 2019, 8:22 PM
brooks accepted this revision.Oct 21 2019, 9:14 PM

This looks good. I would like to commit it myself along with an update of the port to limit needless rebuilds (options changes require PORTREVISION bumps).

This revision is now accepted and ready to land.Oct 21 2019, 9:14 PM
alfredo added a comment.Oct 21 2019, 10:07 PM
In D22100#483005, @brooks wrote:

This looks good. I would like to commit it myself along with an update of the port to limit needless rebuilds (options changes require PORTREVISION bumps).

Thanks! I'll prepare the patch for llvm90, it should be the same.
This change depends on D22039 to be active, but it looks safe to be committed anytime since ".if defined(PPC_ABI)" guards it.

Closed by commit rP515154: Update to a new snapshot. (authored by brooks). · Explain WhyOct 21 2019, 11:53 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rP515154: Update to a new snapshot..
brooks mentioned this in rP515213: Fix build without CLANG enabled. [0].Oct 22 2019, 7:07 PM
brooks mentioned this in rP515935: MFH: r513490 r514194 r515213.Oct 28 2019, 9:04 PM

Revision Contents
Changeset List

PathSize
devel/
llvm-devel/
10 lines
files/
ppc64-elfv2/
23 lines
34 lines

Diff 63519

View Options

devel/llvm-devel/Makefile

Show First 20 Lines • Show All 587 Lines • ▼ Show 20 Linesstruct ifmultiaddr {
struct ifnet *ifma_ifp; /* back-pointer to interface */ struct ifnet *ifma_ifp; /* back-pointer to interface */
u_int ifma_refcount; /* reference count */ u_int ifma_refcount; /* reference count */
int ifma_flags; int ifma_flags;
void *ifma_protospec; /* protocol-specific state, if any */ void *ifma_protospec; /* protocol-specific state, if any */
struct ifmultiaddr *ifma_llifma; /* pointer to ifma for ifma_lladdr */ struct ifmultiaddr *ifma_llifma; /* pointer to ifma for ifma_lladdr */
struct epoch_context ifma_epoch_ctx; struct epoch_context ifma_epoch_ctx;
}; };
extern struct rwlock ifnet_rwlock;
extern struct sx ifnet_sxlock; extern struct sx ifnet_sxlock;
#define IFNET_WLOCK() do { \ #define IFNET_WLOCK() do { \
sx_xlock(&ifnet_sxlock); \ sx_xlock(&ifnet_sxlock); \
rw_wlock(&ifnet_rwlock); \
} while (0) } while (0)
#define IFNET_WUNLOCK() do { \ #define IFNET_WUNLOCK() do { \
rw_wunlock(&ifnet_rwlock); \
sx_xunlock(&ifnet_sxlock); \ sx_xunlock(&ifnet_sxlock); \
} while (0) } while (0)
/*
* To assert the ifnet lock, you must know not only whether it's for read or
* write, but also whether it was acquired with sleep support or not.
*/
#define IFNET_RLOCK_ASSERT() sx_assert(&ifnet_sxlock, SA_SLOCKED) #define IFNET_RLOCK_ASSERT() sx_assert(&ifnet_sxlock, SA_SLOCKED)
kevansUnsubmitted
Done
Inline Actions

This comment should just go away entirely, probably... you only need to know whether it's for read or write now.

kevans: This comment should just go away entirely, probably... you only need to know whether it's for…
#define IFNET_WLOCK_ASSERT() do { \ #define IFNET_WLOCK_ASSERT() do { \
sx_assert(&ifnet_sxlock, SA_XLOCKED); \ sx_assert(&ifnet_sxlock, SA_XLOCKED); \
rw_assert(&ifnet_rwlock, RA_WLOCKED); \
} while (0) } while (0)
#define IFNET_RLOCK() sx_slock(&ifnet_sxlock) #define IFNET_RLOCK() sx_slock(&ifnet_sxlock)
#define IFNET_RUNLOCK() sx_sunlock(&ifnet_sxlock) #define IFNET_RUNLOCK() sx_sunlock(&ifnet_sxlock)
/* /*
* Look up an ifnet given its index; the _ref variant also acquires a * Look up an ifnet given its index; the _ref variant also acquires a
* reference that must be freed using if_rele(). It is almost always a bug * reference that must be freed using if_rele(). It is almost always a bug
▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines
View Options

devel/llvm-devel/files/ppc64-elfv2/patch-lib_Target_PowerPC_PPCTargetMachine.cpp

Show First 20 Lines • Show All 587 Lines • ▼ Show 20 Linesstruct ifmultiaddr {
struct ifnet *ifma_ifp; /* back-pointer to interface */ struct ifnet *ifma_ifp; /* back-pointer to interface */
u_int ifma_refcount; /* reference count */ u_int ifma_refcount; /* reference count */
int ifma_flags; int ifma_flags;
void *ifma_protospec; /* protocol-specific state, if any */ void *ifma_protospec; /* protocol-specific state, if any */
struct ifmultiaddr *ifma_llifma; /* pointer to ifma for ifma_lladdr */ struct ifmultiaddr *ifma_llifma; /* pointer to ifma for ifma_lladdr */
struct epoch_context ifma_epoch_ctx; struct epoch_context ifma_epoch_ctx;
}; };
extern struct rwlock ifnet_rwlock;
extern struct sx ifnet_sxlock; extern struct sx ifnet_sxlock;
#define IFNET_WLOCK() do { \ #define IFNET_WLOCK() do { \
sx_xlock(&ifnet_sxlock); \ sx_xlock(&ifnet_sxlock); \
rw_wlock(&ifnet_rwlock); \
} while (0) } while (0)
#define IFNET_WUNLOCK() do { \ #define IFNET_WUNLOCK() do { \
rw_wunlock(&ifnet_rwlock); \
sx_xunlock(&ifnet_sxlock); \ sx_xunlock(&ifnet_sxlock); \
} while (0) } while (0)
/*
* To assert the ifnet lock, you must know not only whether it's for read or
* write, but also whether it was acquired with sleep support or not.
*/
#define IFNET_RLOCK_ASSERT() sx_assert(&ifnet_sxlock, SA_SLOCKED) #define IFNET_RLOCK_ASSERT() sx_assert(&ifnet_sxlock, SA_SLOCKED)
kevansUnsubmitted
Done
Inline Actions

This comment should just go away entirely, probably... you only need to know whether it's for read or write now.

kevans: This comment should just go away entirely, probably... you only need to know whether it's for…
#define IFNET_WLOCK_ASSERT() do { \ #define IFNET_WLOCK_ASSERT() do { \
sx_assert(&ifnet_sxlock, SA_XLOCKED); \ sx_assert(&ifnet_sxlock, SA_XLOCKED); \
rw_assert(&ifnet_rwlock, RA_WLOCKED); \
} while (0) } while (0)
#define IFNET_RLOCK() sx_slock(&ifnet_sxlock) #define IFNET_RLOCK() sx_slock(&ifnet_sxlock)
#define IFNET_RUNLOCK() sx_sunlock(&ifnet_sxlock) #define IFNET_RUNLOCK() sx_sunlock(&ifnet_sxlock)
/* /*
* Look up an ifnet given its index; the _ref variant also acquires a * Look up an ifnet given its index; the _ref variant also acquires a
* reference that must be freed using if_rele(). It is almost always a bug * reference that must be freed using if_rele(). It is almost always a bug
▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines
View Options

devel/llvm-devel/files/ppc64-elfv2/patch-tools_clang_lib_Basic_Targets_PPC.h

Show First 20 Lines • Show All 587 Lines • ▼ Show 20 Linesstruct ifmultiaddr {
struct ifnet *ifma_ifp; /* back-pointer to interface */ struct ifnet *ifma_ifp; /* back-pointer to interface */
u_int ifma_refcount; /* reference count */ u_int ifma_refcount; /* reference count */
int ifma_flags; int ifma_flags;
void *ifma_protospec; /* protocol-specific state, if any */ void *ifma_protospec; /* protocol-specific state, if any */
struct ifmultiaddr *ifma_llifma; /* pointer to ifma for ifma_lladdr */ struct ifmultiaddr *ifma_llifma; /* pointer to ifma for ifma_lladdr */
struct epoch_context ifma_epoch_ctx; struct epoch_context ifma_epoch_ctx;
}; };
extern struct rwlock ifnet_rwlock;
extern struct sx ifnet_sxlock; extern struct sx ifnet_sxlock;
#define IFNET_WLOCK() do { \ #define IFNET_WLOCK() do { \
sx_xlock(&ifnet_sxlock); \ sx_xlock(&ifnet_sxlock); \
rw_wlock(&ifnet_rwlock); \
} while (0) } while (0)
#define IFNET_WUNLOCK() do { \ #define IFNET_WUNLOCK() do { \
rw_wunlock(&ifnet_rwlock); \
sx_xunlock(&ifnet_sxlock); \ sx_xunlock(&ifnet_sxlock); \
} while (0) } while (0)
/*
* To assert the ifnet lock, you must know not only whether it's for read or
* write, but also whether it was acquired with sleep support or not.
*/
#define IFNET_RLOCK_ASSERT() sx_assert(&ifnet_sxlock, SA_SLOCKED) #define IFNET_RLOCK_ASSERT() sx_assert(&ifnet_sxlock, SA_SLOCKED)
kevansUnsubmitted
Done
Inline Actions

This comment should just go away entirely, probably... you only need to know whether it's for read or write now.

kevans: This comment should just go away entirely, probably... you only need to know whether it's for…
#define IFNET_WLOCK_ASSERT() do { \ #define IFNET_WLOCK_ASSERT() do { \
sx_assert(&ifnet_sxlock, SA_XLOCKED); \ sx_assert(&ifnet_sxlock, SA_XLOCKED); \
rw_assert(&ifnet_rwlock, RA_WLOCKED); \
} while (0) } while (0)
#define IFNET_RLOCK() sx_slock(&ifnet_sxlock) #define IFNET_RLOCK() sx_slock(&ifnet_sxlock)
#define IFNET_RUNLOCK() sx_sunlock(&ifnet_sxlock) #define IFNET_RUNLOCK() sx_sunlock(&ifnet_sxlock)
/* /*
* Look up an ifnet given its index; the _ref variant also acquires a * Look up an ifnet given its index; the _ref variant also acquires a
* reference that must be freed using if_rele(). It is almost always a bug * reference that must be freed using if_rele(). It is almost always a bug
▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines