Page MenuHomeFreeBSD
Differential D22274

graphics/mesa-dri: fix build on powerpc64 elfv2
ClosedPublic
Actions

Authored by pkubaj on Nov 7 2019, 12:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 22 2024, 6:04 PM
Unknown Object (File)
Oct 13 2024, 5:15 AM
Unknown Object (File)
Oct 4 2024, 8:47 AM
Unknown Object (File)
Oct 4 2024, 6:34 AM
Unknown Object (File)
Oct 3 2024, 11:06 AM
Unknown Object (File)
Oct 1 2024, 7:19 PM
Unknown Object (File)
Sep 29 2024, 11:13 PM
Unknown Object (File)
Sep 24 2024, 3:20 AM
View All Files
Subscribers
mikael

Details

Reviewers
linimon
mat
tcberner
zeising
Commits
rP518673: graphics/mesa-dri: fix build on powerpc64 elfv2
Summary

Base LLVM9 fails to build this port with clang crash (reported on https://bugs.llvm.org/show_bug.cgi?id=43862). The port builds when using LLVM8. Since we depend on LLVM8 anyway, use it also for compilation on elfv2.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkubaj created this revision.Nov 7 2019, 12:45 PM
Harbormaster completed remote builds in B27387: Diff 64036.Nov 7 2019, 12:45 PM
pkubaj added a parent revision: D22039: Mk/bsd.port.mk: detect powerpc64 abi .Nov 7 2019, 12:46 PM
mikael added a subscriber: mikael.Nov 8 2019, 3:35 PM
mikael added inline comments.
graphics/mesa-dri/Makefile.common
91 ↗(On Diff #64036)

Why do you need to specify the abi? it should be the default on elfv2.

pkubaj added inline comments.Nov 8 2019, 4:05 PM
graphics/mesa-dri/Makefile.common
91 ↗(On Diff #64036)

It's not default for LLVM8 from ports.

linimon added a comment.Nov 8 2019, 7:40 PM

This builds on ppcports.

OTOH do you think I should try a build of all depenent ports before we proceed? I am not sure.

pkubaj added a comment.Nov 9 2019, 1:04 PM

This shouldn't be needed. Mesa built with base LLVM8 before.

tcberner accepted this revision.Nov 9 2019, 6:38 PM

Looks good to me. But please don't commit until you get approval by @zeising .

This revision is now accepted and ready to land.Nov 9 2019, 6:38 PM
zeising accepted this revision.Nov 29 2019, 4:07 PM
Closed by commit rP518673: graphics/mesa-dri: fix build on powerpc64 elfv2 (authored by pkubaj). · Explain WhyNov 29 2019, 9:37 PM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP518673: graphics/mesa-dri: fix build on powerpc64 elfv2.

Revision Contents
Changeset List

PathSize
head/
graphics/
mesa-dri/
6 lines

Diff 65062

View Options

head/graphics/mesa-dri/Makefile.common

Loading...