Differential D22044

Clear PGA_WRITEABLE in moea_remove_pvo().
ClosedPublic
Actions

Authored by markj on Oct 15 2019, 10:08 PM.

Details

Reviewers

alc
kib
jhibbits
bdragon

Commits

rS353650: Clear PGA_WRITEABLE in moea_pvo_remove().

Summary

The MOEA pmap clears PGA_WRITEABLE in pmap_remove_{all,write}(), but
fails to do so when a single mapping is removed via pmap_remove().
Correct this.

I couldn't find any other places that were missing this: this pmap does
not implement pmap_remove_pages(), and when a CoW fault removes the last
mapping of a page, its PV entry is removed using moea_remove_pvo().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 15 2019, 10:08 PM

Herald added subscribers: bdragon, jhibbits. · View Herald TranscriptOct 15 2019, 10:08 PM

Harbormaster completed remote builds in B27053: Diff 63325.Oct 15 2019, 10:08 PM

markj added reviewers: alc, kib, jhibbits, bdragon.Oct 15 2019, 10:09 PM

markj mentioned this in D22041: Fix assert in powerpc pmaps after introduction of object busy..

Tested on G4 in combination with D22041.

bdragon accepted this revision.Oct 16 2019, 1:47 AM

This revision is now accepted and ready to land.Oct 16 2019, 1:47 AM

alc accepted this revision.Oct 16 2019, 2:50 AM

kib accepted this revision.Oct 16 2019, 6:49 AM

Closed by commit rS353650: Clear PGA_WRITEABLE in moea_pvo_remove(). (authored by markj). · Explain WhyOct 16 2019, 3:50 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS353650: Clear PGA_WRITEABLE in moea_pvo_remove()..

Herald added a subscriber: imp. · View Herald TranscriptOct 16 2019, 3:50 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

aim/

mmu_oea.c

17 lines

Diff 63369

View Options

head/sys/powerpc/aim/mmu_oea.c

Clear PGA_WRITEABLE in moea_remove_pvo().ClosedPublicActions