Disallow fcntl(F_READAHEAD) when the vnode is not a regular file.
ClosedPublic
Actions

Authored by markj on Oct 1 2019, 8:19 PM.

Details

Reviewers

asomers
kib

Commits

rS353010: Disallow fcntl(F_READAHEAD) when the vnode is not a regular file.

Summary

f_iosize is 0 for devfs vnodes, resulting in a divide by zero if one
calls, for example, fcntl(STDIN_FILENO, F_READAHEAD, 4096).

The sequential heuristic is not applied to I/O to or from device files,
and posix_fadvise(2) returns an error for v_type != VREG, so do the same
here too.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 1 2019, 8:19 PM

markj added reviewers: asomers, kib.Oct 1 2019, 8:20 PM

Harbormaster completed remote builds in B26817: Diff 62807.Oct 1 2019, 8:20 PM

mjg added a subscriber: mjg.Oct 1 2019, 8:31 PM

mjg added inline comments.

sys/kern/kern_descrip.c
791 ↗	(On Diff #62807)	vnode is assigned the line prior

Address mjg's note.

Harbormaster completed remote builds in B26818: Diff 62809.Oct 1 2019, 8:34 PM

kib accepted this revision.Oct 1 2019, 9:14 PM

This revision is now accepted and ready to land.Oct 1 2019, 9:14 PM

Closed by commit rS353010: Disallow fcntl(F_READAHEAD) when the vnode is not a regular file. (authored by markj). · Explain WhyOct 2 2019, 3:46 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS353010: Disallow fcntl(F_READAHEAD) when the vnode is not a regular file..

Herald added a subscriber: imp. · View Herald TranscriptOct 2 2019, 3:46 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_descrip.c

6 lines

Diff 62837

View Options

head/sys/kern/kern_descrip.c

Disallow fcntl(F_READAHEAD) when the vnode is not a regular file.ClosedPublicActions