Page MenuHomeFreeBSD

Disallow fcntl(F_READAHEAD) when the vnode is not a regular file.
ClosedPublic

Authored by markj on Oct 1 2019, 8:19 PM.
Tags
None
Referenced Files
F134605020: D21864.id62807.diff
Mon, Nov 3, 1:17 PM
F134601294: D21864.id62837.diff
Mon, Nov 3, 12:53 PM
F134601284: D21864.id62809.diff
Mon, Nov 3, 12:53 PM
F134601256: D21864.id62807.diff
Mon, Nov 3, 12:53 PM
F134600963: D21864.diff
Mon, Nov 3, 12:52 PM
Unknown Object (File)
Sat, Nov 1, 2:54 PM
Unknown Object (File)
Fri, Oct 31, 11:10 PM
Unknown Object (File)
Mon, Oct 27, 1:40 AM
Subscribers

Details

Summary

f_iosize is 0 for devfs vnodes, resulting in a divide by zero if one
calls, for example, fcntl(STDIN_FILENO, F_READAHEAD, 4096).

The sequential heuristic is not applied to I/O to or from device files,
and posix_fadvise(2) returns an error for v_type != VREG, so do the same
here too.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26817
Build 25151: arc lint + arc unit