Differential D2854

Fix issues with the libxo'ing of /bin/ls
ClosedPublic
Actions

Authored by allanjude on Jun 18 2015, 5:09 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 5, 4:43 PM

	Unknown Object (File)
	Thu, Nov 28, 6:15 AM

	Unknown Object (File)
	Nov 10 2024, 12:03 PM

	Unknown Object (File)
	Oct 18 2024, 4:56 PM

	Unknown Object (File)
	Oct 6 2024, 11:02 PM

	Unknown Object (File)
	Sep 30 2024, 11:28 PM

	Unknown Object (File)
	Sep 30 2024, 1:48 PM

	Unknown Object (File)
	Sep 20 2024, 1:14 PM

Subscribers

Details

Reviewers

• rodrigc
eadler
ngie
marcel

Commits

rS285734: Fix some issues with the application of libxo to ls(1)

Summary

Add whitespace trimming to some fields (username, group, size, inode, blocks) to avoid whitespace in JSON strings
fix -m mode, was invalid JSON (repeated keys), and was missing outer array container
in -n mode, numeric uids and gids were returned as strings

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

allanjude updated this revision to Diff 6281.Jun 18 2015, 5:09 AM

allanjude retitled this revision from to Fix issues with the libxo'ing of /bin/ls.

allanjude updated this object.

allanjude edited the test plan for this revision. (Show Details)

allanjude added reviewers: marcel, ngie, • rodrigc.

Herald added a subscriber: imp. · View Herald TranscriptJun 18 2015, 5:09 AM

allanjude added a reviewer: eadler.Jul 21 2015, 4:29 AM

eadler accepted this revision.Jul 21 2015, 4:38 AM

eadler edited edge metadata.

This revision is now accepted and ready to land.Jul 21 2015, 4:38 AM

Update diff

This revision now requires review to proceed.Jul 21 2015, 4:38 AM

Undo last change.

Closed by commit rS285734: Fix some issues with the application of libxo to ls(1) (authored by allanjude). · Explain WhyJul 21 2015, 5:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

bin/

ls/

3 lines

3 lines

50 lines

Diff 6281

bin/ls/ls.h

Loading...

bin/ls/ls.c

Loading...

bin/ls/print.c

Loading...