Disallow fcntl(F_READAHEAD) when the vnode is not a regular file.
ClosedPublic
Actions

Authored by markj on Oct 1 2019, 8:19 PM.

Details

Reviewers

asomers
kib

Commits

rS353010: Disallow fcntl(F_READAHEAD) when the vnode is not a regular file.

Summary

f_iosize is 0 for devfs vnodes, resulting in a divide by zero if one
calls, for example, fcntl(STDIN_FILENO, F_READAHEAD, 4096).

The sequential heuristic is not applied to I/O to or from device files,
and posix_fadvise(2) returns an error for v_type != VREG, so do the same
here too.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26818
Build 25152: arc lint + arc unit

Event Timeline

markj created this revision.Oct 1 2019, 8:19 PM

markj added reviewers: asomers, kib.Oct 1 2019, 8:20 PM

Harbormaster completed remote builds in B26817: Diff 62807.Oct 1 2019, 8:20 PM

mjg added a subscriber: mjg.Oct 1 2019, 8:31 PM

mjg added inline comments.

sys/kern/kern_descrip.c
791	vnode is assigned the line prior

Address mjg's note.

Harbormaster completed remote builds in B26818: Diff 62809.Oct 1 2019, 8:34 PM

kib accepted this revision.Oct 1 2019, 9:14 PM

This revision is now accepted and ready to land.Oct 1 2019, 9:14 PM

Closed by commit rS353010: Disallow fcntl(F_READAHEAD) when the vnode is not a regular file. (authored by markj). · Explain WhyOct 2 2019, 3:46 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS353010: Disallow fcntl(F_READAHEAD) when the vnode is not a regular file..

Herald added a subscriber: imp. · View Herald TranscriptOct 2 2019, 3:46 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_descrip.c

6 lines

Diff 62809

View Options

sys/kern/kern_descrip.c

	%%DATADIR%%/COPYING.linux			%%DATADIR%%/COPYING.linux
	%%DATADIR%%/LICENCE.broadcom			%%DATADIR%%/LICENCE.broadcom
	%%DATADIR%%/armstub8.bin			%%DATADIR%%/armstub8.bin
	%%DATADIR%%/bcm2708-rpi-0-w.dtb			%%DATADIR%%/bcm2708-rpi-0-w.dtb
	%%DATADIR%%/bcm2708-rpi-b-plus.dtb			%%DATADIR%%/bcm2708-rpi-b-plus.dtb
	%%DATADIR%%/bcm2708-rpi-b.dtb			%%DATADIR%%/bcm2708-rpi-b.dtb
	%%DATADIR%%/bcm2708-rpi-cm.dtb			%%DATADIR%%/bcm2708-rpi-cm.dtb
	%%DATADIR%%/bcm2709-rpi-2-b.dtb			%%DATADIR%%/bcm2709-rpi-2-b.dtb
	%%DATADIR%%/bcm2710-rpi-3-b-plus.dtb			%%DATADIR%%/bcm2710-rpi-3-b-plus.dtb
	%%DATADIR%%/bcm2710-rpi-3-b.dtb			%%DATADIR%%/bcm2710-rpi-3-b.dtb
	%%DATADIR%%/bcm2710-rpi-cm3.dtb			%%DATADIR%%/bcm2710-rpi-cm3.dtb
	%%DATADIR%%/bootcode.bin			%%DATADIR%%/bootcode.bin
	%%DATADIR%%/config.txt			%%DATADIR%%/config.txt
				%%DATADIR%%/config_rpi_0_w.txt
	%%DATADIR%%/config_rpi3.txt			%%DATADIR%%/config_rpi3.txt
	%%DATADIR%%/fixup.dat			%%DATADIR%%/fixup.dat
	%%DATADIR%%/fixup_cd.dat			%%DATADIR%%/fixup_cd.dat
	%%DATADIR%%/fixup_db.dat			%%DATADIR%%/fixup_db.dat
	%%DATADIR%%/fixup_x.dat			%%DATADIR%%/fixup_x.dat
	%%DATADIR%%/overlays/README			%%DATADIR%%/overlays/README
	%%DATADIR%%/overlays/adau1977-adc.dtbo			%%DATADIR%%/overlays/adau1977-adc.dtbo
	%%DATADIR%%/overlays/adau7002-simple.dtbo			%%DATADIR%%/overlays/adau7002-simple.dtbo
	▲ Show 20 Lines • Show All 133 Lines • Show Last 20 Lines

Disallow fcntl(F_READAHEAD) when the vnode is not a regular file.ClosedPublicActions