linux_renameat2: don't add extra \n on error
ClosedPublic
Actions

Authored by kaktus on Sep 30 2019, 3:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 1, 11:55 AM

	Unknown Object (File)
	Wed, May 1, 11:55 AM

	Unknown Object (File)
	Wed, May 1, 11:26 AM

	Unknown Object (File)
	Wed, May 1, 3:38 AM

	Unknown Object (File)
	Thu, Apr 25, 6:42 AM

	Unknown Object (File)
	Dec 20 2023, 1:38 AM

	Unknown Object (File)
	Aug 26 2023, 7:44 PM

	Unknown Object (File)
	Jul 6 2023, 2:34 PM

View All 16 Files

Subscribers

imp

Details

Reviewers

kib
mjg
emaste

Commits

rS352914: linux_renameat2: don't add extra \n on error.

Summary

linux_renameat2: don't add extra \n on error.

linux_msg() already adds \n at the end of all messages.

Test Plan

expected:
Sep 30 15:09:21 devel2 kernel: linux: pid 24804 (mv): renameat2 unsupported flags 0x1

actual:
Sep 30 15:09:21 devel2 kernel: linux: pid 24804 (mv): renameat2 unsupported flags 0x1
Sep 30 15:09:21 devel2 kernel:

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kaktus created this revision.Sep 30 2019, 3:39 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 30 2019, 3:39 PM

mjg accepted this revision.Sep 30 2019, 3:41 PM

This revision is now accepted and ready to land.Sep 30 2019, 3:41 PM

emaste accepted this revision.Sep 30 2019, 4:03 PM

kib accepted this revision.Sep 30 2019, 4:24 PM

Closed by commit rS352914: linux_renameat2: don't add extra \n on error. (authored by kaktus). · Explain WhySep 30 2019, 7:05 PM

This revision was automatically updated to reflect the committed changes.

kaktus added a commit: rS352914: linux_renameat2: don't add extra \n on error..

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linux/

linux_file.c

2 lines

Diff 62766

View Options

head/sys/compat/linux/linux_file.c

linux_renameat2: don't add extra \n on errorClosedPublicActions