Page MenuHomeFreeBSD
Differential D21853

Check for ipv6_zoneid in tcp_hc_lookup() alongside inc6_faddr
AbandonedPublic
Actions

Authored by nc on Sep 30 2019, 5:58 PM.
Tags
None
Referenced Files
F98627661: D21853.id62778.diff
Fri, Oct 4, 3:49 AM
Unknown Object (File)
Sun, Sep 22, 9:45 PM
Unknown Object (File)
Sun, Sep 22, 2:03 AM
Unknown Object (File)
Thu, Sep 12, 2:05 PM
Unknown Object (File)
Mon, Sep 9, 4:07 AM
Unknown Object (File)
Sat, Sep 7, 10:21 AM
Unknown Object (File)
Sat, Sep 7, 7:28 AM
Unknown Object (File)
Aug 31 2024, 6:02 AM
View All 24 Files
Subscribers
ae
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
bz
tuexen
Summary

When looking through bucket entries in the hostcache, we only looked at inc6_faddr. This patch adds support for looking at ipv6_zoneid as well.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

nc created this revision.Sep 30 2019, 5:58 PM
Herald added a reviewer: transport. · View Herald TranscriptSep 30 2019, 5:58 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
nc edited the summary of this revision. (Show Details)Sep 30 2019, 5:58 PM
nc removed a reviewer: transport.Sep 30 2019, 7:08 PM
nc added reviewers: bz, tuexen.Sep 30 2019, 8:00 PM
nc updated this revision to Diff 62778.Sep 30 2019, 10:14 PM

Old patch freezes on IPv6 startup, so I fixed the issue with this update.

I'm new to the kernel, sorry.

ae added a subscriber: ae.Oct 1 2019, 1:11 PM

I'm agree with the change, but I have doubts that we have fixed all places in the kernel, where zone id is checked and properly initialized. Usually we keep zone id embedded in the address. Do you have some tests to check this code?

nc abandoned this revision.Mar 31 2020, 1:34 AM
Herald added a subscriber: melifaro. · View Herald TranscriptMar 31 2020, 1:34 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
5 lines

Diff 62764

View Options

sys/netinet/tcp_hostcache.c

Loading...