Differential D21107

Capsicumize nm(1).
ClosedPublic
Actions

Authored by markj on Jul 29 2019, 7:35 PM.

Tags

None

Referenced Files

	F154620372: D21107.id62761.diff
	Wed, Apr 29, 1:36 AM

	F154618299: D21107.id62761.diff
	Wed, Apr 29, 1:29 AM

	F154364327: D21107.id62762.diff
	Tue, Apr 28, 3:16 AM

	Unknown Object (File)
	Mon, Apr 27, 1:40 PM

	Unknown Object (File)
	Tue, Apr 21, 10:47 PM

	Unknown Object (File)
	Sun, Apr 19, 10:43 PM

	Unknown Object (File)
	Sat, Apr 18, 6:38 PM

	Unknown Object (File)
	Thu, Apr 16, 1:23 AM

Subscribers

jkoshy_users.sourceforge.net

Details

Reviewers

oshogbo
emaste

Group Reviewers

Commits

rS352909: Capsicumize nm(1).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 29 2019, 7:35 PM

Herald added a subscriber: jonathan. · View Herald TranscriptJul 29 2019, 7:35 PM

Harbormaster completed remote builds in B25572: Diff 60246.Jul 29 2019, 7:35 PM

markj added reviewers: capsicum, oshogbo, emaste.Jul 29 2019, 7:45 PM

emaste added subscribers: kaiw, jkoshy_users.sourceforge.net.Aug 16 2019, 4:11 PM

looks good

contrib/elftoolchain/nm/nm.c
27–30 ↗	(On Diff #60246)	suggest committing this (and similar changes from other ELF Tool Chain tools) independently first, and I'll upstream those immediately
2158–2159 ↗	(On Diff #60246)	These changes too could be upstreamed independently

Get rid of style fixes in #includes.
Update argc and argv in get_opt(). I think this is a bit neater.

Harbormaster completed remote builds in B26798: Diff 62761.Sep 30 2019, 5:05 PM

markj added inline comments.Sep 30 2019, 5:08 PM

contrib/elftoolchain/nm/nm.c
27–30 ↗	(On Diff #60246)	I just dropped those changes.
2158–2159 ↗	(On Diff #60246)	I will commit that separately and post a patch to elftoolchain-developers.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 30 2019, 5:28 PM

Closed by commit rS352909: Capsicumize nm(1). (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS352909: Capsicumize nm(1)..

Herald added a subscriber: imp. · View Herald TranscriptSep 30 2019, 5:28 PM

Revision Contents
Changeset List

Path

Size

head/

contrib/

elftoolchain/

nm/

41 lines

usr.bin/

nm/

6 lines

Diff 62762

head/contrib/elftoolchain/nm/nm.c

Loading...

head/usr.bin/nm/Makefile

Loading...