Page MenuHomeFreeBSD

Style cleanup in elf_machdep.c
ClosedPublic

Authored by mhorne on Sep 24 2019, 12:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 7:54 PM
Unknown Object (File)
Sat, Jan 25, 7:40 PM
Unknown Object (File)
Thu, Jan 23, 6:59 PM
Unknown Object (File)
Sat, Jan 18, 5:35 PM
Unknown Object (File)
Fri, Jan 17, 6:52 PM
Unknown Object (File)
Sun, Jan 12, 10:13 PM
Unknown Object (File)
Thu, Jan 9, 9:29 PM
Unknown Object (File)
Thu, Jan 9, 11:56 AM
Subscribers

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26661
Build 25035: arc lint + arc unit

Event Timeline

Remove an extra set of redundant parenthesis.

sys/riscv/riscv/elf_machdep.c
116

Note that changing sysctl types is technically not a style change since userland code which reads the value using an int will be broken. We've had regressions in the past when a similar change was merged to a stable branch. I think it's fine in this case: we don't currently aim to preserve binary compatibility for RISC-V and I doubt that there is any C code that toggles this sysctl.

Since you're changing the type, could you also move the sysctl under the debug OID? Maybe debug.kld_reloc or so.

319

I'd also get rid of the blank lines around this assignment.

416

The indentation is still wrong here.

Address markj's comments.
Remove some additional blank lines.

This revision is now accepted and ready to land.Sep 25 2019, 12:09 AM
This revision was automatically updated to reflect the committed changes.