Details
Details
- Reviewers
markj br kp - Commits
- rS354261: MFC r352729:
rS352729: Cleanup of elf_machdep.c
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26661 Build 25035: arc lint + arc unit
Event Timeline
| sys/riscv/riscv/elf_machdep.c | ||
|---|---|---|
| 116 | Note that changing sysctl types is technically not a style change since userland code which reads the value using an int will be broken. We've had regressions in the past when a similar change was merged to a stable branch. I think it's fine in this case: we don't currently aim to preserve binary compatibility for RISC-V and I doubt that there is any C code that toggles this sysctl. Since you're changing the type, could you also move the sysctl under the debug OID? Maybe debug.kld_reloc or so. | |
| 319 | I'd also get rid of the blank lines around this assignment. | |
| 416 | The indentation is still wrong here. | |