Page MenuHomeFreeBSD

Style cleanup in elf_machdep.c
ClosedPublic

Authored by mhorne on Sep 24 2019, 12:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 9:05 AM
Unknown Object (File)
Wed, Dec 11, 6:41 AM
Unknown Object (File)
Tue, Dec 10, 7:21 AM
Unknown Object (File)
Wed, Nov 27, 11:22 AM
Unknown Object (File)
Nov 22 2024, 12:58 PM
Unknown Object (File)
Nov 20 2024, 12:32 AM
Unknown Object (File)
Nov 20 2024, 12:29 AM
Unknown Object (File)
Nov 19 2024, 12:22 AM
Subscribers

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26681
Build 25049: arc lint + arc unit

Event Timeline

Remove an extra set of redundant parenthesis.

sys/riscv/riscv/elf_machdep.c
116

Note that changing sysctl types is technically not a style change since userland code which reads the value using an int will be broken. We've had regressions in the past when a similar change was merged to a stable branch. I think it's fine in this case: we don't currently aim to preserve binary compatibility for RISC-V and I doubt that there is any C code that toggles this sysctl.

Since you're changing the type, could you also move the sysctl under the debug OID? Maybe debug.kld_reloc or so.

316–317

I'd also get rid of the blank lines around this assignment.

405–407

The indentation is still wrong here.

Address markj's comments.
Remove some additional blank lines.

This revision is now accepted and ready to land.Sep 25 2019, 12:09 AM
This revision was automatically updated to reflect the committed changes.