sysctl: use names instead of magic numbers
ClosedPublic
Actions

Authored by kaktus on Sep 17 2019, 10:55 PM.

Details

Reviewers

kib
mjg

Commits

rS352486: sysctl: use names instead of magic numbers.

Summary

Replace magic numbers with names for internal sysctl operations.
Convert in-kernel and libc consumers.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kaktus created this revision.Sep 17 2019, 10:55 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 17 2019, 10:55 PM

kaktus mentioned this in D21688: make truss decode sysctl names.Sep 17 2019, 10:57 PM

kaktus added a child revision: D21688: make truss decode sysctl names.Sep 17 2019, 11:00 PM

kib accepted this revision.Sep 18 2019, 6:33 AM

kib added inline comments.

sys/kern/kern_sysctl.c
939	Please add space after comma

This revision is now accepted and ready to land.Sep 18 2019, 6:33 AM

Add space after comma.

This revision now requires review to proceed.Sep 18 2019, 8:30 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2019, 4:13 PM

Closed by commit rS352486: sysctl: use names instead of magic numbers. (authored by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS352486: sysctl: use names instead of magic numbers..

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

sysctlnametomib.c

4 lines

sys/

kern/

kern_sysctl.c

61 lines

sys/

sysctl.h

13 lines

Diff 62258

View Options

lib/libc/gen/sysctlnametomib.c

View Options

sys/kern/kern_sysctl.c

View Options

sysctl: use names instead of magic numbersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 62258

lib/libc/gen/sysctlnametomib.c

sys/kern/kern_sysctl.c

sys/sys/sysctl.h

sysctl: use names instead of magic numbers
ClosedPublic
Actions

Revision Contents
Changeset List