Page MenuHomeFreeBSD
Differential D21693

sysctl: use names instead of magic numbers
ClosedPublic
Actions

Authored by kaktus on Sep 17 2019, 10:55 PM.
Tags
None
Referenced Files
F136953309: D21693.id62270.diff
Thu, Nov 20, 7:55 PM
F136953208: D21693.id62258.diff
Thu, Nov 20, 7:54 PM
F136953185: D21693.id62240.diff
Thu, Nov 20, 7:54 PM
F136952584: D21693.id.diff
Thu, Nov 20, 7:51 PM
F136950743: D21693.diff
Thu, Nov 20, 7:42 PM
Unknown Object (File)
Tue, Nov 18, 4:59 PM
Unknown Object (File)
Tue, Nov 18, 12:09 PM
Unknown Object (File)
Sat, Nov 8, 2:59 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
mjg
Commits
rS352486: sysctl: use names instead of magic numbers.
Summary

Replace magic numbers with names for internal sysctl operations.
Convert in-kernel and libc consumers.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kaktus created this revision.Sep 17 2019, 10:55 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 17 2019, 10:55 PM
kaktus mentioned this in D21688: make truss decode sysctl names.Sep 17 2019, 10:57 PM
kaktus added a child revision: D21688: make truss decode sysctl names.Sep 17 2019, 11:00 PM
kib accepted this revision.Sep 18 2019, 6:33 AM
kib added inline comments.
sys/kern/kern_sysctl.c
939

Please add space after comma

This revision is now accepted and ready to land.Sep 18 2019, 6:33 AM
kaktus updated this revision to Diff 62258.Sep 18 2019, 8:30 AM
kaktus edited the summary of this revision. (Show Details)

Add space after comma.

This revision now requires review to proceed.Sep 18 2019, 8:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2019, 4:13 PM
Closed by commit rS352486: sysctl: use names instead of magic numbers. (authored by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS352486: sysctl: use names instead of magic numbers..

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
4 lines
sys/
kern/
61 lines
sys/
13 lines

Diff 62258

View Options

lib/libc/gen/sysctlnametomib.c

Loading...
View Options

sys/kern/kern_sysctl.c

Loading...
View Options

sys/sys/sysctl.h

Loading...