Page MenuHomeFreeBSD
Differential D21575

vfs: manage mnt_writeopcount with atomics
ClosedPublic
Actions

Authored by mjg on Sep 9 2019, 12:07 PM.
Tags
None
Referenced Files
F132594206: D21575.id61836.diff
Sat, Oct 18, 6:34 AM
F132594189: D21575.id.diff
Sat, Oct 18, 6:33 AM
F132594185: D21575.id62130.diff
Sat, Oct 18, 6:33 AM
F132594184: D21575.id62110.diff
Sat, Oct 18, 6:33 AM
F132594174: D21575.id62114.diff
Sat, Oct 18, 6:33 AM
F132594173: D21575.id62184.diff
Sat, Oct 18, 6:33 AM
Unknown Object (File)
Fri, Oct 17, 7:42 PM
Unknown Object (File)
Mon, Oct 6, 2:25 AM
View All 98 Files
Subscribers
imp

Details

Reviewers
kib
jeff
Commits
rS352426: vfs: manage mnt_writeopcount with atomics
Summary

This requires a small hack in SU code which disables suspension "by hand". I did not think it's worthwhile making it use a generic routine.

Tested by pho

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mjg created this revision.Sep 9 2019, 12:07 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 9 2019, 12:07 PM
Harbormaster completed remote builds in B26355: Diff 61836.Sep 9 2019, 12:07 PM
mjg added a parent revision: D21425: vfs: manage mnt_ref with atomics.Sep 9 2019, 12:22 PM
mjg added a child revision: D21637: vfs: convert struct mount counters to per-cpu.Sep 13 2019, 4:32 PM
mjg updated this revision to Diff 62110.Sep 14 2019, 9:09 PM
  • rebase on top of the custom barrier
kib accepted this revision.Sep 14 2019, 9:35 PM
kib added inline comments.
sys/kern/vfs_vnops.c
1638

I think you can write
if (__predict_true(!mplocked && (flags & V_XSLEEP) == 0) && vfs_op_thread_enter(mp)) {
and remove that ugly slowpath label.

This revision is now accepted and ready to land.Sep 14 2019, 9:35 PM
mjg updated this revision to Diff 62114.Sep 14 2019, 10:28 PM
  • remove the slowpath label
This revision now requires review to proceed.Sep 14 2019, 10:28 PM
mjg updated this revision to Diff 62130.Sep 15 2019, 7:55 PM
  • fix parens placement
kib accepted this revision.Sep 16 2019, 7:29 AM
This revision is now accepted and ready to land.Sep 16 2019, 7:29 AM
jeff accepted this revision.Sep 16 2019, 8:53 PM
jeff added inline comments.
sys/kern/vfs_vnops.c
1807–1809

Since we do this twice it could just be part of a macro or inline.

Closed by commit rS352426: vfs: manage mnt_writeopcount with atomics (authored by mjg). · Explain WhySep 16 2019, 9:33 PM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rS352426: vfs: manage mnt_writeopcount with atomics.

Revision Contents
Changeset List

PathSize
sys/
kern/
62 lines
ufs/
ffs/
9 lines

Diff 62110

View Options

sys/kern/vfs_vnops.c

Loading...
View Options

sys/ufs/ffs/ffs_softdep.c

Loading...