Page MenuHomeFreeBSD

vfs: manage mnt_writeopcount with atomics
ClosedPublic

Authored by mjg on Sep 9 2019, 12:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 5:51 AM
Unknown Object (File)
Sat, Mar 8, 1:14 PM
Unknown Object (File)
Thu, Mar 6, 11:07 AM
Unknown Object (File)
Fri, Feb 21, 10:50 AM
Unknown Object (File)
Thu, Feb 20, 2:29 AM
Unknown Object (File)
Tue, Feb 18, 5:39 PM
Unknown Object (File)
Mon, Feb 17, 7:48 AM
Unknown Object (File)
Mon, Feb 17, 6:12 AM
Subscribers

Details

Summary

This requires a small hack in SU code which disables suspension "by hand". I did not think it's worthwhile making it use a generic routine.

Tested by pho

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

  • rebase on top of the custom barrier
kib added inline comments.
sys/kern/vfs_vnops.c
1638

I think you can write
if (__predict_true(!mplocked && (flags & V_XSLEEP) == 0) && vfs_op_thread_enter(mp)) {
and remove that ugly slowpath label.

This revision is now accepted and ready to land.Sep 14 2019, 9:35 PM
  • remove the slowpath label
This revision now requires review to proceed.Sep 14 2019, 10:28 PM
This revision is now accepted and ready to land.Sep 16 2019, 7:29 AM
jeff added inline comments.
sys/kern/vfs_vnops.c
1807–1809

Since we do this twice it could just be part of a macro or inline.

This revision was automatically updated to reflect the committed changes.