Page MenuHomeFreeBSD

vfs: manage mnt_writeopcount with atomics
ClosedPublic

Authored by mjg on Sep 9 2019, 12:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 7, 6:26 AM
Unknown Object (File)
Mon, May 5, 6:33 AM
Unknown Object (File)
Sat, May 3, 12:04 AM
Unknown Object (File)
Thu, May 1, 6:33 AM
Unknown Object (File)
Wed, Apr 30, 2:59 AM
Unknown Object (File)
Mon, Apr 21, 3:02 AM
Unknown Object (File)
Sun, Apr 20, 12:44 PM
Unknown Object (File)
Apr 17 2025, 3:07 AM
Subscribers

Details

Summary

This requires a small hack in SU code which disables suspension "by hand". I did not think it's worthwhile making it use a generic routine.

Tested by pho

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • rebase on top of the custom barrier
kib added inline comments.
sys/kern/vfs_vnops.c
1638 ↗(On Diff #62110)

I think you can write
if (__predict_true(!mplocked && (flags & V_XSLEEP) == 0) && vfs_op_thread_enter(mp)) {
and remove that ugly slowpath label.

This revision is now accepted and ready to land.Sep 14 2019, 9:35 PM
  • remove the slowpath label
This revision now requires review to proceed.Sep 14 2019, 10:28 PM
This revision is now accepted and ready to land.Sep 16 2019, 7:29 AM
jeff added inline comments.
sys/kern/vfs_vnops.c
1800–1802 ↗(On Diff #62130)

Since we do this twice it could just be part of a macro or inline.

This revision was automatically updated to reflect the committed changes.