Page MenuHomeFreeBSD

vfs: manage mnt_writeopcount with atomics
ClosedPublic

Authored by mjg on Sep 9 2019, 12:07 PM.
Tags
None
Referenced Files
F110354599: D21575.diff
Mon, Feb 17, 6:12 AM
Unknown Object (File)
Thu, Feb 6, 12:50 PM
Unknown Object (File)
Jan 8 2025, 1:44 AM
Unknown Object (File)
Jan 4 2025, 8:34 AM
Unknown Object (File)
Dec 31 2024, 10:35 AM
Unknown Object (File)
Dec 9 2024, 12:12 PM
Unknown Object (File)
Dec 6 2024, 4:48 PM
Unknown Object (File)
Nov 30 2024, 8:53 AM
Subscribers

Details

Summary

This requires a small hack in SU code which disables suspension "by hand". I did not think it's worthwhile making it use a generic routine.

Tested by pho

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 26355

Event Timeline

  • rebase on top of the custom barrier
kib added inline comments.
sys/kern/vfs_vnops.c
1640

I think you can write
if (__predict_true(!mplocked && (flags & V_XSLEEP) == 0) && vfs_op_thread_enter(mp)) {
and remove that ugly slowpath label.

This revision is now accepted and ready to land.Sep 14 2019, 9:35 PM
  • remove the slowpath label
This revision now requires review to proceed.Sep 14 2019, 10:28 PM
This revision is now accepted and ready to land.Sep 16 2019, 7:29 AM
jeff added inline comments.
sys/kern/vfs_vnops.c
1810–1812

Since we do this twice it could just be part of a macro or inline.

This revision was automatically updated to reflect the committed changes.