Differential D21640

Document logic for __DEFAULT_DEPENDENT_OPTIONS
ClosedPublic
Actions

Authored by sjg on Sep 13 2019, 5:57 PM.

Tags

None

Referenced Files

	F171665811: D21640.id62136.diff
	Sat, Sep 12, 1:13 PM

	Unknown Object (File)
	Fri, Sep 11, 9:09 AM

	Unknown Object (File)
	Sun, Sep 6, 2:39 AM

	Unknown Object (File)
	Sun, Sep 6, 2:32 AM

	Unknown Object (File)
	Sat, Sep 5, 5:09 PM

	Unknown Object (File)
	Sat, Sep 5, 5:08 PM

	Unknown Object (File)
	Sat, Sep 5, 7:38 AM

	Unknown Object (File)
	Fri, Sep 4, 1:51 PM

Subscribers

Details

Reviewers

bdrewery
stevek

Commits

rS352782: Document logic for __DEFAULT_DEPENDENT_OPTIONS
rS352370: Document logic for __DEFAULT_DEPENDENT_OPTIONS

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26496
Build 24907: arc lint + arc unit

Event Timeline

sjg created this revision.Sep 13 2019, 5:57 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptSep 13 2019, 5:57 PM

Harbormaster completed remote builds in B26469: Diff 62045.Sep 13 2019, 5:57 PM

sjg added reviewers: bdrewery, stevek.Sep 13 2019, 6:01 PM

stevek added inline comments.Sep 13 2019, 6:08 PM

share/mk/bsd.mkopt.mk
16	Perhaps "or the value of MK_BAR if both WITH_FOO and WITHOUT_FOO are not defined." would be clearer? Otherwise it looks fine to me.

Use otherwise

Harbormaster completed remote builds in B26496: Diff 62096.Sep 14 2019, 3:55 PM

stevek accepted this revision.Sep 16 2019, 12:12 AM

This revision is now accepted and ready to land.Sep 16 2019, 12:12 AM

Closed by commit rS352370: Document logic for __DEFAULT_DEPENDENT_OPTIONS (authored by sjg). · Explain WhySep 16 2019, 12:32 AM

This revision was automatically updated to reflect the committed changes.

sjg added a commit: rS352370: Document logic for __DEFAULT_DEPENDENT_OPTIONS.

sjg added a commit: rS352782: Document logic for __DEFAULT_DEPENDENT_OPTIONS.Sep 27 2019, 12:11 AM

Revision Contents
Changeset List

Path

Size

share/

mk/

10 lines

Diff 62096

share/mk/bsd.mkopt.mk

Loading...