sys/arm64/arm64/smccc-call.S
38 ↗	(On Diff #61355)	I think you mean `struct arm_smccc_res *res`.
42 ↗	(On Diff #61355)	You could allow for `NULL` to be passed as `res` by checking `x4` is non-zero, e.g. cbz x4, 1f stp ... stp ... 1f: ret Alternatively if `x8` is preserved you could return the `struct arm_smccc_res` directly. The caller will allocate space for it and pass a pointer to the memory in `x8` (assuming I'm remembering the ABI correctly).
50 ↗	(On Diff #61355)	And here.

address Andy's comments

br marked 3 inline comments as done.Sep 3 2019, 5:43 PM

br added inline comments.

sys/arm64/include/arm-smccc.h
1 ↗	(On Diff #61355)	Hmm I'm not sure where to put it then. Any idea ?

Can you update the psci code to use the arm_smccc_* functions? We should only have one copy the functions to make smccc calls and you can consider psci to be based on it.

sys/arm64/include/arm-smccc.h
1 ↗	(On Diff #61355)	I would leave the code where it was and add your changes to `sys/dev/psci/smccc.h`. `sys/arm64/arm64/smccc-call.S` should also be moved to `sys/dev/psci/smccc_arm64.S`.

Reuse generic SMCCC for PSCI.

br edited the summary of this revision. (Show Details)Sep 6 2019, 3:09 PM

In D21439#469311, @andrew wrote:

Can you update the psci code to use the arm_smccc_* functions? We should only have one copy the functions to make smccc calls and you can consider psci to be based on it.

OK I updated. I did not test on arm since I dont have PSCI-enabled arm hardware

andrew accepted this revision.Sep 11 2019, 4:36 PM

This revision is now accepted and ready to land.Sep 11 2019, 4:36 PM

Closed by commit rS352301: Add generic arm/arm64 secure-monitor SMCCC interface and switch (authored by br). · Explain WhySep 13 2019, 3:56 PM

This revision was automatically updated to reflect the committed changes.

br added a commit: rS352301: Add generic arm/arm64 secure-monitor SMCCC interface and switch.

Herald added a subscriber: imp. · View Herald TranscriptSep 13 2019, 3:56 PM