Page MenuHomeFreeBSD
Differential D21442

Fix qmath(3) with new GCC
ClosedPublic
Actions

Authored by trasz on Aug 27 2019, 6:30 PM.
Tags
None
Referenced Files
F137003188: D21442.id61445.diff
Thu, Nov 20, 11:22 PM
F137001323: D21442.id61366.diff
Thu, Nov 20, 11:16 PM
F137001032: D21442.id61445.diff
Thu, Nov 20, 11:15 PM
F136999518: D21442.id61366.diff
Thu, Nov 20, 11:09 PM
F136999414: D21442.id.diff
Thu, Nov 20, 11:09 PM
F136999374: D21442.id.diff
Thu, Nov 20, 11:09 PM
F136997786: D21442.diff
Thu, Nov 20, 11:02 PM
F136997366: D21442.diff
Thu, Nov 20, 11:01 PM
View All 73 Files
Subscribers
imp
lwhsu

Details

Reviewers
sef
asomers
Commits
rS351596: Fix qmath(3) build problems with GCC 8.
Summary

Fix build problems in qmath(3) with new GCC. Trivial, except for the signedness part in qmath.h.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26139
Build 24656: arc lint + arc unit

Event Timeline

trasz created this revision.Aug 27 2019, 6:30 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 27 2019, 6:30 PM
Harbormaster completed remote builds in B26139: Diff 61366.Aug 27 2019, 6:30 PM
trasz edited the summary of this revision. (Show Details)Aug 27 2019, 6:31 PM
trasz added reviewers: sef, asomers.Aug 27 2019, 6:36 PM
trasz mentioned this in D21451: Fix (some of) warnings from riscv64-gcc.Aug 28 2019, 10:36 AM

Note to self: tinderboxed.

lwhsu added a subscriber: lwhsu.Aug 28 2019, 1:57 PM
asomers added inline comments.Aug 28 2019, 2:54 PM
sys/sys/qmath.h
270

Technically, shouldn't you cast it _before_ inverting it?

-(int64_t)(Q_ABS(iv) << Q_NFBITS(q))
trasz marked an inline comment as done.Aug 29 2019, 7:39 AM

Note that I'm committing it without waiting for a proper acceptance due to being a build fix.

sys/sys/qmath.h
270

Thanks; fixed.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2019, 7:39 AM
Closed by commit rS351596: Fix qmath(3) build problems with GCC 8. (authored by trasz). · Explain Why
This revision was automatically updated to reflect the committed changes.
trasz marked an inline comment as done.
trasz added a commit: rS351596: Fix qmath(3) build problems with GCC 8..

Revision Contents
Changeset List

PathSize
sys/
sys/
2 lines
tests/
sys/
sys/
16 lines

Diff 61366

View Options

sys/sys/qmath.h

Loading...
View Options

tests/sys/sys/qmath_test.c

Loading...