Page MenuHomeFreeBSD

Fix qmath(3) with new GCC
ClosedPublic

Authored by trasz on Aug 27 2019, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 9 2024, 6:36 PM
Unknown Object (File)
Dec 25 2023, 4:25 PM
Unknown Object (File)
Dec 20 2023, 6:51 AM
Unknown Object (File)
Dec 7 2023, 1:17 AM
Unknown Object (File)
Nov 15 2023, 10:54 PM
Unknown Object (File)
Nov 11 2023, 12:28 PM
Unknown Object (File)
Nov 9 2023, 12:33 PM
Unknown Object (File)
Oct 30 2023, 11:23 PM
Subscribers

Details

Summary

Fix build problems in qmath(3) with new GCC. Trivial, except for the signedness part in qmath.h.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/sys/qmath.h
270 ↗(On Diff #61366)

Technically, shouldn't you cast it _before_ inverting it?

-(int64_t)(Q_ABS(iv) << Q_NFBITS(q))

Note that I'm committing it without waiting for a proper acceptance due to being a build fix.

sys/sys/qmath.h
270 ↗(On Diff #61366)

Thanks; fixed.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2019, 7:39 AM
This revision was automatically updated to reflect the committed changes.
trasz marked an inline comment as done.