Page MenuHomeFreeBSD
Differential D21409

mixer(8): Report an error if passed value is an empty string
ClosedPublic
Actions

Authored by 0mp on Aug 24 2019, 10:47 PM.
Tags
None
Referenced Files
F168879380: D21409.id61246.diff
Sun, Aug 30, 2:12 PM
Unknown Object (File)
Thu, Aug 27, 8:39 PM
Unknown Object (File)
Wed, Aug 26, 6:51 PM
Unknown Object (File)
Tue, Aug 25, 2:21 PM
Unknown Object (File)
Tue, Aug 25, 2:16 AM
Unknown Object (File)
Tue, Aug 11, 5:13 AM
Unknown Object (File)
Mon, Aug 10, 4:04 PM
Unknown Object (File)
Mon, Aug 10, 4:03 PM
View All Files
Subscribers
imp

Details

Reviewers
• hselasky
mav
ed
Group Reviewers
multimedia
Commits
rS351481: mixer(8): Report an error if the passed value is an empty string
Summary
mixer(8): Report an error if passed value is an empty string

This patch fixes a bug that made the mixer command enter an infinite loop
when instructed to set the value of a device to an empty string (e.g., `mixer vol ""`).

Additionally, some tests for mixer(8) are being added.

PR:	240039
Test Plan
$ sudo mkdir -p /usr/tests/usr.sbin/mixer/
$ cd src/usr.sbin/mixer
$ make && sudo make install && (cd /usr/tests/usr.sbin/mixer/ && kyua test)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Aug 24 2019, 10:47 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 24 2019, 10:47 PM
Harbormaster completed remote builds in B26089: Diff 61246.Aug 24 2019, 10:47 PM
0mp added reviewers: • hselasky, multimedia.Aug 24 2019, 10:49 PM
0mp updated this revision to Diff 61247.Aug 24 2019, 10:51 PM

Fix a typo in an atf_test description

Harbormaster completed remote builds in B26090: Diff 61247.Aug 24 2019, 10:51 PM
0mp added reviewers: mav, ed.Aug 24 2019, 11:38 PM
mav accepted this revision.Aug 25 2019, 1:37 AM

Looks good to me. Just thinking whether -1 or EOF is more appropriate.

This revision is now accepted and ready to land.Aug 25 2019, 1:37 AM
• hselasky accepted this revision.Aug 25 2019, 2:43 PM
0mp added a comment.Aug 25 2019, 3:00 PM
In D21409#465784, @mav wrote:

Looks good to me. Just thinking whether -1 or EOF is more appropriate.

Probably EOF. I'll change it in the final commit.

Also, do we want to MFC this change?

mav added a comment.Aug 25 2019, 3:11 PM
In D21409#465864, @0mp wrote:

Also, do we want to MFC this change?

Probably. Why not.

Closed by commit rS351481: mixer(8): Report an error if the passed value is an empty string (authored by 0mp). · Explain WhyAug 25 2019, 5:55 PM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rS351481: mixer(8): Report an error if the passed value is an empty string.
0mp mentioned this in rS358955: MFC 351481, 357619:.Mar 13 2020, 11:27 AM

Revision Contents
Changeset List

PathSize
head/
etc/
mtree/
2 lines
usr.sbin/
mixer/
5 lines
5 lines
tests/
5 lines
123 lines

Diff 61262

View Options

head/etc/mtree/BSD.tests.dist

Loading...
View Options

head/usr.sbin/mixer/Makefile

Loading...
View Options

head/usr.sbin/mixer/mixer.c

Loading...
View Options

head/usr.sbin/mixer/tests/Makefile

Loading...
View Options

head/usr.sbin/mixer/tests/mixer_test.sh

Loading...