Page MenuHomeFreeBSD

mixer(8): Report an error if passed value is an empty string
ClosedPublic

Authored by 0mp on Aug 24 2019, 10:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 12 2024, 9:48 AM
Unknown Object (File)
Mar 12 2024, 9:48 AM
Unknown Object (File)
Mar 12 2024, 9:44 AM
Unknown Object (File)
Mar 12 2024, 9:44 AM
Unknown Object (File)
Mar 8 2024, 5:33 AM
Unknown Object (File)
Jan 4 2024, 10:31 PM
Unknown Object (File)
Jan 4 2024, 10:31 PM
Unknown Object (File)
Jan 4 2024, 10:31 PM
Subscribers

Details

Summary
mixer(8): Report an error if passed value is an empty string

This patch fixes a bug that made the mixer command enter an infinite loop
when instructed to set the value of a device to an empty string (e.g., `mixer vol ""`).

Additionally, some tests for mixer(8) are being added.

PR:	240039
Test Plan
$ sudo mkdir -p /usr/tests/usr.sbin/mixer/
$ cd src/usr.sbin/mixer
$ make && sudo make install && (cd /usr/tests/usr.sbin/mixer/ && kyua test)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fix a typo in an atf_test description

Looks good to me. Just thinking whether -1 or EOF is more appropriate.

This revision is now accepted and ready to land.Aug 25 2019, 1:37 AM
In D21409#465784, @mav wrote:

Looks good to me. Just thinking whether -1 or EOF is more appropriate.

Probably EOF. I'll change it in the final commit.

Also, do we want to MFC this change?

In D21409#465864, @0mp wrote:

Also, do we want to MFC this change?

Probably. Why not.