This regression was introduced in the r326169 Linux v4.9 Infiniband upgrade.
Restore the functionality.
Details
Details
- Reviewers
markj • hselasky rstone - Commits
- rS351176: OFED: Unbreak SDP support in ibcore
Basic functionality established with mthca(4) devices.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good. See my one comment.
sys/ofed/include/rdma/rdma_sdp.h | ||
---|---|---|
28 ↗ | (On Diff #60926) | Can you change this into a normal include guard? |
sys/ofed/include/rdma/rdma_sdp.h | ||
---|---|---|
28 ↗ | (On Diff #60926) | I prefer once, but if you have a strong preference for the boilerplate, I'm happy to change it. |
Comment Actions
If all compilers support \#pragma once I'm fine with that, but else we should follow the style in FreeBSD.
Comment Actions
All compilers do support #pragma once: https://en.wikipedia.org/wiki/Pragma_once#Portability
(The list we care about is much shorter: Clang and GCC.)