Page MenuHomeFreeBSD

OFED: Unbreak SDP support in ibcore
ClosedPublic

Authored by cem on Aug 17 2019, 3:16 AM.

Details

Summary

This regression was introduced in the r326169 Linux v4.9 Infiniband upgrade.
Restore the functionality.

Test Plan

Basic functionality established with mthca(4) devices.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem created this revision.Aug 17 2019, 3:16 AM
hselasky accepted this revision.Aug 17 2019, 8:15 AM

Looks good. See my one comment.

sys/ofed/include/rdma/rdma_sdp.h
28 ↗(On Diff #60926)

Can you change this into a normal include guard?

This revision is now accepted and ready to land.Aug 17 2019, 8:15 AM
cem added inline comments.Aug 17 2019, 9:31 AM
sys/ofed/include/rdma/rdma_sdp.h
28 ↗(On Diff #60926)

I prefer once, but if you have a strong preference for the boilerplate, I'm happy to change it.

If all compilers support \#pragma once I'm fine with that, but else we should follow the style in FreeBSD.

cem added a comment.Aug 17 2019, 10:13 AM

If all compilers support \#pragma once I'm fine with that, but else we should follow the style in FreeBSD.

All compilers do support #pragma once: https://en.wikipedia.org/wiki/Pragma_once#Portability

(The list we care about is much shorter: Clang and GCC.)

This revision was automatically updated to reflect the committed changes.
cem marked an inline comment as done.