Page MenuHomeFreeBSD
Differential D21298

OFED: Unbreak SDP support in ibcore
ClosedPublic
Actions

Authored by cem on Aug 17 2019, 3:16 AM.
Tags
None
Referenced Files
F136937164: D21298.id60952.diff
Thu, Nov 20, 6:11 PM
F136937093: D21298.id.diff
Thu, Nov 20, 6:10 PM
F136937068: D21298.id60926.diff
Thu, Nov 20, 6:10 PM
F136935378: D21298.diff
Thu, Nov 20, 5:59 PM
Unknown Object (File)
Sun, Nov 16, 3:21 AM
Unknown Object (File)
Sun, Nov 16, 12:29 AM
Unknown Object (File)
Sun, Nov 16, 12:06 AM
Unknown Object (File)
Wed, Nov 5, 12:29 AM
View All 80 Files
Subscribers
imp

Details

Reviewers
markj
• hselasky
rstone
Commits
rS351176: OFED: Unbreak SDP support in ibcore
Summary

This regression was introduced in the r326169 Linux v4.9 Infiniband upgrade.
Restore the functionality.

Test Plan

Basic functionality established with mthca(4) devices.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25929
Build 24493: arc lint + arc unit

Event Timeline

cem created this revision.Aug 17 2019, 3:16 AM
Harbormaster completed remote builds in B25929: Diff 60926.Aug 17 2019, 3:16 AM
• hselasky accepted this revision.Aug 17 2019, 8:15 AM

Looks good. See my one comment.

sys/ofed/include/rdma/rdma_sdp.h
28

Can you change this into a normal include guard?

This revision is now accepted and ready to land.Aug 17 2019, 8:15 AM
cem added inline comments.Aug 17 2019, 9:31 AM
sys/ofed/include/rdma/rdma_sdp.h
28

I prefer once, but if you have a strong preference for the boilerplate, I'm happy to change it.

• hselasky added a comment.Aug 17 2019, 10:03 AM

If all compilers support \#pragma once I'm fine with that, but else we should follow the style in FreeBSD.

cem added a comment.Aug 17 2019, 10:13 AM
In D21298#463284, @hselasky wrote:

If all compilers support \#pragma once I'm fine with that, but else we should follow the style in FreeBSD.

All compilers do support #pragma once: https://en.wikipedia.org/wiki/Pragma_once#Portability

(The list we care about is much shorter: Clang and GCC.)

Closed by commit rS351176: OFED: Unbreak SDP support in ibcore (authored by cem). · Explain WhyAug 17 2019, 6:54 PM
This revision was automatically updated to reflect the committed changes.
cem marked an inline comment as done.
cem added a commit: rS351176: OFED: Unbreak SDP support in ibcore.
Herald added a subscriber: imp. · View Herald TranscriptAug 17 2019, 6:54 PM

Revision Contents
Changeset List

PathSize
sys/
ofed/
drivers/
infiniband/
core/
233 lines
ulp/
sdp/
44 lines
include/
rdma/
75 lines

Diff 60926

View Options

sys/ofed/drivers/infiniband/core/ib_cma.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/sdp/sdp.h

Loading...
View Options

sys/ofed/include/rdma/rdma_sdp.h

Loading...