[PPC64] Fix rtld direct exec mode
ClosedPublic
Actions

Authored by luporl on Aug 1 2019, 8:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 25, 7:01 AM

	Unknown Object (File)
	Fri, Sep 25, 7:01 AM

	Unknown Object (File)
	Fri, Sep 25, 6:36 AM

	Unknown Object (File)
	Wed, Sep 23, 4:20 AM

	Unknown Object (File)
	Sun, Sep 20, 3:52 PM

	Unknown Object (File)
	Sun, Sep 20, 1:43 PM

	Unknown Object (File)
	Sat, Sep 12, 6:09 AM

	Unknown Object (File)
	Sep 7 2026, 10:48 PM

View All Files

Subscribers

alfredo

imp

Details

Reviewers

jhibbits
bdragon

Commits

rS350587: [PPC64] Fix rtld direct exec mode

Summary

Instead of restoring the saved values of argc, argv and envp,
these must be loaded from the stack that _rtld() modifies.

This fixes rtld direct exec mode.
E.g.: /libexec/ld-elf.so.1 /bin/ls

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25633
Build 24226: arc lint + arc unit

Event Timeline

luporl created this revision.Aug 1 2019, 8:38 PM

Harbormaster completed remote builds in B25633: Diff 60376.Aug 1 2019, 8:38 PM

Looks good. Can the same change apply to powerpc?

This revision is now accepted and ready to land.Aug 3 2019, 11:58 AM

In D21131#459452, @jhibbits wrote:

Looks good. Can the same change apply to powerpc?

A brief look at powerpc/rtld_start.S code seems to indicate that the same changes apply to powerpc.

But it would be better for someone with 32-bit powerpc hardware to make the change and confirm it works fine.

Closed by commit rS350587: [PPC64] Fix rtld direct exec mode (authored by luporl). · Explain WhyAug 5 2019, 1:22 PM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rS350587: [PPC64] Fix rtld direct exec mode.

Herald added a subscriber: imp. · View Herald TranscriptAug 5 2019, 1:22 PM

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

powerpc64/

rtld_start.S

18 lines

Diff 60376

View Options

libexec/rtld-elf/powerpc64/rtld_start.S

[PPC64] Fix rtld direct exec modeClosedPublicActions