Page MenuHomeFreeBSD

[PPC64] Fix rtld direct exec mode
ClosedPublic

Authored by luporl on Aug 1 2019, 8:38 PM.
Tags
None
Referenced Files
F160235749: D21131.id.diff
Mon, Jun 22, 11:07 AM
Unknown Object (File)
Sat, Jun 20, 5:23 AM
Unknown Object (File)
Thu, Jun 4, 1:09 PM
Unknown Object (File)
Thu, Jun 4, 4:29 AM
Unknown Object (File)
Wed, Jun 3, 3:57 PM
Unknown Object (File)
Mon, May 25, 7:16 PM
Unknown Object (File)
Sun, May 24, 6:39 PM
Unknown Object (File)
May 2 2026, 11:49 AM
Subscribers

Details

Summary

Instead of restoring the saved values of argc, argv and envp,
these must be loaded from the stack that _rtld() modifies.

This fixes rtld direct exec mode.
E.g.: /libexec/ld-elf.so.1 /bin/ls

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good. Can the same change apply to powerpc?

This revision is now accepted and ready to land.Aug 3 2019, 11:58 AM

Looks good. Can the same change apply to powerpc?

A brief look at powerpc/rtld_start.S code seems to indicate that the same changes apply to powerpc.

But it would be better for someone with 32-bit powerpc hardware to make the change and confirm it works fine.

This revision was automatically updated to reflect the committed changes.