Differential D21107

Capsicumize nm(1).
ClosedPublic
Actions

Authored by markj on Jul 29 2019, 7:35 PM.

Tags

None

Referenced Files

	F150657765: D21107.diff
	Fri, Apr 3, 3:57 AM

	Unknown Object (File)
	Mon, Mar 23, 1:25 PM

	Unknown Object (File)
	Sat, Mar 21, 11:07 AM

	Unknown Object (File)
	Sat, Mar 21, 3:30 AM

	Unknown Object (File)
	Thu, Mar 19, 9:20 AM

	Unknown Object (File)
	Wed, Mar 18, 6:45 AM

	Unknown Object (File)
	Wed, Mar 18, 1:50 AM

	Unknown Object (File)
	Tue, Mar 17, 6:39 PM

Subscribers

jkoshy_users.sourceforge.net

Details

Reviewers

oshogbo
emaste

Group Reviewers

Commits

rS352909: Capsicumize nm(1).

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25572
Build 24177: arc lint + arc unit

Event Timeline

markj created this revision.Jul 29 2019, 7:35 PM

Herald added a subscriber: jonathan. · View Herald TranscriptJul 29 2019, 7:35 PM

Harbormaster completed remote builds in B25572: Diff 60246.Jul 29 2019, 7:35 PM

markj added reviewers: capsicum, oshogbo, emaste.Jul 29 2019, 7:45 PM

emaste added subscribers: kaiw, jkoshy_users.sourceforge.net.Aug 16 2019, 4:11 PM

looks good

contrib/elftoolchain/nm/nm.c
27–30	suggest committing this (and similar changes from other ELF Tool Chain tools) independently first, and I'll upstream those immediately
2158–2159	These changes too could be upstreamed independently

Get rid of style fixes in #includes.
Update argc and argv in get_opt(). I think this is a bit neater.

Harbormaster completed remote builds in B26798: Diff 62761.Sep 30 2019, 5:05 PM

markj added inline comments.Sep 30 2019, 5:08 PM

contrib/elftoolchain/nm/nm.c
27–30	I just dropped those changes.
2158–2159	I will commit that separately and post a patch to elftoolchain-developers.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 30 2019, 5:28 PM

Closed by commit rS352909: Capsicumize nm(1). (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS352909: Capsicumize nm(1)..

Herald added a subscriber: imp. · View Herald TranscriptSep 30 2019, 5:28 PM

Revision Contents
Changeset List

Path

Size

contrib/

elftoolchain/

nm/

48 lines

usr.bin/

nm/

6 lines

Diff 60246

contrib/elftoolchain/nm/nm.c

Loading...

usr.bin/nm/Makefile

Loading...