Page MenuHomeFreeBSD

Fix epoch's use of turnstile_lock().
ClosedPublic

Authored by markj on Jul 24 2019, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 23, 2:38 AM
Unknown Object (File)
Thu, Dec 18, 5:25 PM
Unknown Object (File)
Wed, Dec 17, 8:15 AM
Unknown Object (File)
Nov 28 2025, 7:10 AM
Unknown Object (File)
Nov 23 2025, 11:18 PM
Unknown Object (File)
Nov 21 2025, 8:25 PM
Unknown Object (File)
Nov 20 2025, 4:47 PM
Unknown Object (File)
Nov 20 2025, 4:47 PM
Subscribers

Details

Summary

turnstile_lock() was added specifically for use in epoch. While waiting
for readers to drain, if the blocking thread discovers a reader blocked
on a turnstile, it will also block on the turnstile. It previously
returned the value of the ts_owner field to indicate that the turnstile
was successfully locked, and NULL to indicate that the race was lost.
But, ts_owner may be NULL if the turnstile corresponds to a rw lock
owned by one or more readers, in which case the epoch code leaked the
turnstile lock and chain lock.

Apply a minimal fix: simply return the owner as a separate value.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable