Page MenuHomeFreeBSD

Fix epoch's use of turnstile_lock().
ClosedPublic

Authored by markj on Jul 24 2019, 1:39 AM.
Tags
None
Referenced Files
F133414391: D21048.id60114.diff
Sat, Oct 25, 3:25 PM
Unknown Object (File)
Fri, Oct 24, 6:44 AM
Unknown Object (File)
Thu, Oct 23, 8:18 PM
Unknown Object (File)
Tue, Oct 21, 11:18 PM
Unknown Object (File)
Mon, Oct 20, 7:26 PM
Unknown Object (File)
Mon, Oct 20, 7:26 PM
Unknown Object (File)
Mon, Oct 20, 7:26 PM
Unknown Object (File)
Mon, Oct 20, 7:11 AM
Subscribers

Details

Summary

turnstile_lock() was added specifically for use in epoch. While waiting
for readers to drain, if the blocking thread discovers a reader blocked
on a turnstile, it will also block on the turnstile. It previously
returned the value of the ts_owner field to indicate that the turnstile
was successfully locked, and NULL to indicate that the race was lost.
But, ts_owner may be NULL if the turnstile corresponds to a rw lock
owned by one or more readers, in which case the epoch code leaked the
turnstile lock and chain lock.

Apply a minimal fix: simply return the owner as a separate value.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable